dblaikie accepted this revision.
dblaikie added a comment.
This revision is now accepted and ready to land.

Looks OK to me - couple of minor questions.



================
Comment at: include/clang/Frontend/CodeGenOptions.def:222
                                     ///< of inline stack frames without .dwo 
files.
+CODEGENOPT(DebugFwdTemplateParams, 1, 0) ///< Whether to emit complete
+                                         ///< template parameter descriptions 
in
----------------
Maybe 'Decl' rather than 'Fwd'.


================
Comment at: test/CodeGenCXX/debug-info-fwd-template-param.cpp:7
+template<typename T> class A;
+A<const int> *p;
+
----------------
Any particular reason for const int, rather than int?


https://reviews.llvm.org/D14358



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to