This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGcad708b9a1ec: [clang-format] Recognize Verilog non-blocking
assignment (authored by sstwcw).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LA
sstwcw updated this revision to Diff 494839.
sstwcw added a comment.
- add parentheses
- rename field
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D142891/new/
https://reviews.llvm.org/D142891
Files:
clang/lib/Format/TokenAnnotator.cpp
clang/l
owenpan added inline comments.
Comment at: clang/lib/Format/TokenAnnotator.cpp:1628
bool InCSharpAttributeSpecifier = false;
+bool AssignmentFound = false;
enum {
Comment at: clang/lib/Format/TokenAnnotator.cpp:1935-1936
+ }
HazardyKnusperkeks accepted this revision.
HazardyKnusperkeks added a comment.
This revision is now accepted and ready to land.
Looks ok to me. Please wait for some other opinion.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D142891/new/
https://re
sstwcw marked an inline comment as done.
sstwcw added inline comments.
Comment at: clang/lib/Format/WhitespaceManager.cpp:839-846
return Style.AlignConsecutiveAssignments.AlignCompound
? C.Tok->getPrecedence() == prec::Assignment
- :
sstwcw updated this revision to Diff 494303.
sstwcw added a comment.
- add parentheses
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D142891/new/
https://reviews.llvm.org/D142891
Files:
clang/lib/Format/TokenAnnotator.cpp
clang/lib/Format/White
HazardyKnusperkeks added inline comments.
Comment at: clang/lib/Format/WhitespaceManager.cpp:839-846
return Style.AlignConsecutiveAssignments.AlignCompound
? C.Tok->getPrecedence() == prec::Assignment
- : C.Tok->is(tok::equal);
+
sstwcw created this revision.
sstwcw added reviewers: HazardyKnusperkeks, MyDeveloperDay, curdeius, owenpan.
Herald added a project: All.
sstwcw requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Repository:
rG LLVM Github Monorepo
https://