[PATCH] D142550: Fix sizeof of boolean vector

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd4f4b2fe21dd: [clang] Fix sizeof of boolean vector (authored by Fznamznon). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[PATCH] D142550: Fix sizeof of boolean vector

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. Ok, thank you! This looks right to me :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142550/new/ https://reviews.llvm.org/D142550 __

[PATCH] D142550: Fix sizeof of boolean vector

Fznamznon added inline comments. Comment at: clang/test/SemaCXX/vector-bool.cpp:97 + using NineBools = bool __attribute__((ext_vector_type(9))); + using ABunchOfBools = bool __attribute__((ext_vector_type(28))); static_assert(sizeof(FourBools) == 1); erichke

[PATCH] D142550: Fix sizeof of boolean vector

Fznamznon updated this revision to Diff 492362. Fznamznon added a comment. Add more sizes to test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142550/new/ https://reviews.llvm.org/D142550 Files: clang/lib/AST/ASTContext.cpp clang/test/SemaCXX

[PATCH] D142550: Fix sizeof of boolean vector

erichkeane added a comment. Just a couple more I'm concerned about after thinking about it, otherwise this looks about right. Comment at: clang/test/SemaCXX/vector-bool.cpp:97 + using NineBools = bool __attribute__((ext_vector_type(9))); + using ABunchOfBools = bool __attrib

[PATCH] D142550: Fix sizeof of boolean vector

Fznamznon added inline comments. Comment at: clang/test/SemaCXX/vector-bool.cpp:97 + using NineBools = bool __attribute__((ext_vector_type(9))); + using ABunchOfBools = bool __attribute__((ext_vector_type(28))); static_assert(sizeof(FourBools) == 1); erichke

[PATCH] D142550: Fix sizeof of boolean vector

Fznamznon updated this revision to Diff 492151. Fznamznon added a comment. Add a case with vector of length 33 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142550/new/ https://reviews.llvm.org/D142550 Files: clang/lib/AST/ASTContext.cpp clang

[PATCH] D142550: Fix sizeof of boolean vector

erichkeane added inline comments. Comment at: clang/test/SemaCXX/vector-bool.cpp:97 + using NineBools = bool __attribute__((ext_vector_type(9))); + using ABunchOfBools = bool __attribute__((ext_vector_type(28))); static_assert(sizeof(FourBools) == 1); How ab

[PATCH] D142550: Fix sizeof of boolean vector

Fznamznon added inline comments. Comment at: clang/test/SemaCXX/vector-bool.cpp:95 +void Sizeof() { + using FourBools = bool __attribute__((ext_vector_type(8))); + static_assert(sizeof(FourBools) == 1); Fznamznon wrote: > erichkeane wrote: > > tbaeder wrote: >

[PATCH] D142550: Fix sizeof of boolean vector

Fznamznon updated this revision to Diff 492125. Fznamznon added a comment. Adjust the test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142550/new/ https://reviews.llvm.org/D142550 Files: clang/test/SemaCXX/vector-bool.cpp Index: clang/test/S

[PATCH] D142550: Fix sizeof of boolean vector

Fznamznon added inline comments. Comment at: clang/test/SemaCXX/vector-bool.cpp:95 +void Sizeof() { + using FourBools = bool __attribute__((ext_vector_type(8))); + static_assert(sizeof(FourBools) == 1); erichkeane wrote: > tbaeder wrote: > > Fznamznon wrote: >

[PATCH] D142550: Fix sizeof of boolean vector

erichkeane added inline comments. Comment at: clang/test/SemaCXX/vector-bool.cpp:95 +void Sizeof() { + using FourBools = bool __attribute__((ext_vector_type(8))); + static_assert(sizeof(FourBools) == 1); tbaeder wrote: > Fznamznon wrote: > > This is not four bo

[PATCH] D142550: Fix sizeof of boolean vector

Fznamznon added inline comments. Comment at: clang/test/SemaCXX/vector-bool.cpp:95 +void Sizeof() { + using FourBools = bool __attribute__((ext_vector_type(8))); + static_assert(sizeof(FourBools) == 1); This is not four bools. Repository: rG LLVM Github Mon

[PATCH] D142550: Fix sizeof of boolean vector

tbaeder added inline comments. Comment at: clang/test/SemaCXX/vector-bool.cpp:95 +void Sizeof() { + using FourBools = bool __attribute__((ext_vector_type(8))); + static_assert(sizeof(FourBools) == 1); Should be 4 instead of 8, shouldn't it? Repository: rG L

[PATCH] D142550: Fix sizeof of boolean vector

Fznamznon created this revision. Herald added a project: All. Fznamznon requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Ensure it is at least 8 bits. Fixes #59801 Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D142550 F