Fznamznon added inline comments.

================
Comment at: clang/test/SemaCXX/vector-bool.cpp:95
+void Sizeof() {
+  using FourBools = bool __attribute__((ext_vector_type(8)));
+  static_assert(sizeof(FourBools) == 1);
----------------
Fznamznon wrote:
> erichkeane wrote:
> > tbaeder wrote:
> > > Fznamznon wrote:
> > > > This is not four bools.
> > > Should be 4 instead of 8, shouldn't it?
> > Can you add another couple of 'oddball' sizes and make sure they work out 
> > right?  I THINK the alignment logic gets it right, but I'd like tests to 
> > confirm.
> Yes, will fix in a moment.
Okay, done.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142550/new/

https://reviews.llvm.org/D142550

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to