hubert.reinterpretcast added a comment.
Since this is a change only for AIX and z/OS, and considering that this is a
patch to prevent ABI changes compared to the current ABI baselines for those
platforms, I will land this ahead of the LLVM 16 branching.
CHANGES SINCE LAST ACTION
https://revi
hubert.reinterpretcast accepted this revision.
hubert.reinterpretcast added a comment.
This revision is now accepted and ready to land.
Thanks @nicolerabjohn; this LGTM!
Comment at: clang/test/SemaCXX/class-layout.cpp:685
+#if (defined(CLANG_ABI_COMPAT) && CLANG_ABI_COMPAT <= 1
nicolerabjohn marked an inline comment as done.
nicolerabjohn added inline comments.
Comment at: clang/test/SemaCXX/class-layout.cpp:688
};
#if defined(CLANG_ABI_COMPAT) && CLANG_ABI_COMPAT <= 15
_Static_assert(sizeof(t3) == 8, "");
hubert.reinterpretcast wrot
nicolerabjohn updated this revision to Diff 491595.
nicolerabjohn added a comment.
Update to assertions for z/OS case.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D142358/new/
https://reviews.llvm.org/D142358
Files:
clang/docs/ReleaseNotes.rst
clang/lib/AST/RecordLayoutBuilder.cpp
hubert.reinterpretcast added inline comments.
Comment at: clang/test/SemaCXX/class-layout.cpp:688
};
#if defined(CLANG_ABI_COMPAT) && CLANG_ABI_COMPAT <= 15
_Static_assert(sizeof(t3) == 8, "");
hubert.reinterpretcast wrote:
> hubert.reinterpretcast wrote:
> >
nicolerabjohn updated this revision to Diff 491505.
nicolerabjohn added a comment.
Reverting previous directive change.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D142358/new/
https://reviews.llvm.org/D142358
Files:
clang/docs/ReleaseNotes.rst
clang/lib/AST/RecordLayoutBuilder.cp
hubert.reinterpretcast added inline comments.
Comment at: clang/test/SemaCXX/class-layout.cpp:18
// expected-no-diagnostics
+#if !defined(__MVS__) && !defined(_AIX)
dblaikie wrote:
> What's the reason this part is #ifdef'd out? Does it contain code that's
> u
hubert.reinterpretcast added inline comments.
Comment at: clang/test/SemaCXX/class-layout.cpp:688
};
#if defined(CLANG_ABI_COMPAT) && CLANG_ABI_COMPAT <= 15
_Static_assert(sizeof(t3) == 8, "");
hubert.reinterpretcast wrote:
> Because z/OS has some of the Clang
dblaikie added inline comments.
Comment at: clang/test/SemaCXX/class-layout.cpp:18
// expected-no-diagnostics
+#if !defined(__MVS__) && !defined(_AIX)
What's the reason this part is #ifdef'd out? Does it contain code that's
unsupported on these platforms?
C
nicolerabjohn updated this revision to Diff 491501.
nicolerabjohn added a comment.
Addressing review comments - spacing, updates to run lines, updates to a
directive.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D142358/new/
https://reviews.llvm.org/D142358
Files:
clang/docs/Release
hubert.reinterpretcast added inline comments.
Comment at: clang/test/SemaCXX/class-layout.cpp:14
+// RUN: %clang_cc1 -triple powerpc64-ibm-aix7.3.0.0 %s -fsyntax-only -verify
-std=c++11 -Wno-inaccessible-base -fclang-abi-compat=15 -DCLANG_ABI_COMPAT=15
+//RUN: %clang_cc1 -triple
hubert.reinterpretcast added inline comments.
Comment at: clang/test/SemaCXX/class-layout.cpp:14
+// RUN: %clang_cc1 -triple powerpc64-ibm-aix7.3.0.0 %s -fsyntax-only -verify
-std=c++11 -Wno-inaccessible-base -fclang-abi-compat=15 -DCLANG_ABI_COMPAT=15
+//RUN: %clang_cc1 -triple
hubert.reinterpretcast added inline comments.
Comment at: clang/docs/ReleaseNotes.rst:817
attribute is also specified on the member. Clang historically did perform
such packing. Clang now matches the gcc behavior (except on Darwin and PS4).
You can switch back to the old
nicolerabjohn updated this revision to Diff 491477.
nicolerabjohn added a comment.
Opting out of clang ABI change in FieldPacked bool on AIX.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D142358/new/
https://reviews.llvm.org/D142358
Files:
clang/docs/ReleaseNotes.rst
clang/lib/AST/
nicolerabjohn updated this revision to Diff 491431.
nicolerabjohn added a comment.
Adding run lines for AIX & z/OS, and updating comment line length.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D142358/new/
https://reviews.llvm.org/D142358
Files:
clang/docs/ReleaseNotes.rst
clang/
dblaikie added inline comments.
Comment at: clang/docs/ReleaseNotes.rst:822
classified such types as non-POD (for the purposes of Itanium ABI). Clang now
- matches the gcc behavior (except on Darwin and PS4). You can switch back to
+ matches the gcc behavior (except on Darwi
hubert.reinterpretcast added inline comments.
Comment at: clang/test/SemaCXX/class-layout.cpp:10
// RUN: %clang_cc1 -triple x86_64-unknown-unknown %s -fsyntax-only -verify
-std=c++11 -Wno-inaccessible-base -fclang-abi-compat=16 -DCLANG_ABI_COMPAT=16
// expected-no-diagnostics
nicolerabjohn updated this revision to Diff 491375.
nicolerabjohn added a comment.
Updating comment
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D142358/new/
https://reviews.llvm.org/D142358
Files:
clang/docs/ReleaseNotes.rst
clang/lib/Basic/Targets/OSTargets.h
clang/test/SemaCXX
daltenty added inline comments.
Comment at: clang/test/SemaCXX/class-layout.cpp:616-617
+// This ends the #if !defined(__MVS__) && !defined(__AIX__) block from line 12
+#endif
+
nit: line numbers may shift on you as other commits touch this file. Prefer a
sa
nicolerabjohn created this revision.
nicolerabjohn added reviewers: hubert.reinterpretcast, cebowleratibm, daltenty,
dblaikie.
Herald added a project: All.
nicolerabjohn requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
There is already a GC
20 matches
Mail list logo
