nicolerabjohn marked an inline comment as done. nicolerabjohn added inline comments.
================ Comment at: clang/test/SemaCXX/class-layout.cpp:688 }; #if defined(CLANG_ABI_COMPAT) && CLANG_ABI_COMPAT <= 15 _Static_assert(sizeof(t3) == 8, ""); ---------------- hubert.reinterpretcast wrote: > hubert.reinterpretcast wrote: > > hubert.reinterpretcast wrote: > > > Because z/OS has some of the Clang 16 changes but not all, I think we > > > can't rely on claiming that it uses the Clang 15 ABI for the purposes of > > > the testing (and need to make a change here to say that it does follow > > > the "Clang 15 ABI" for this aspect). > > Sorry, my last suggestion for this line should be reverted. z/OS works just > > like Linux for this right now: no special code needed here. > > Sorry, my last suggestion for this line should be reverted. z/OS works just > > like Linux for this right now: no special code needed here. > > I was actually confused about being confused before (and now I am just very > confused). This is the test corresponding to the changes to > `areDefaultedSMFStillPOD`. z/OS does not work just like Linux for this part. > Under `__MVS__`, we really should always be returning `8` for the size of > `t3`. I am not sure how we ended up with `12` as I was told offline. > I discussed offline with Hubert, and we went through the test cases. My updated diff has applied Hubert's original suggestion for this line, as well as a similar change for line 684 to update the assertions for the z/OS case. This test case now passes all the AIX & z/OS run lines. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142358/new/ https://reviews.llvm.org/D142358 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
