[PATCH] D142315: [clang] Add test for CWG1111

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5fc73b7502fb: [clang] Add test for CWG (authored by Endill). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D142315: [clang] Add test for CWG1111

Endill updated this revision to Diff 492430. Endill edited the summary of this revision. Endill added a comment. Move CWG2385 ("na") from D142316 into this patch. It makes more sense to put it here, because it fixes inconsistent wording introduced by CWG re

[PATCH] D142315: [clang] Add test for CWG1111

Endill added inline comments. Comment at: clang/test/CXX/drs/dr11xx.cpp:1 -// RUN: %clang_cc1 -std=c++98 %s -verify -fexceptions -fcxx-exceptions -pedantic-errors +// RUN: %clang_cc1 -std=c++98 %s -verify=expected,cxx98 -fexceptions -fcxx-exceptions -pedantic-errors // RUN: %c

[PATCH] D142315: [clang] Add test for CWG1111

Endill updated this revision to Diff 492395. Endill added a comment. Change status from "6" to "yes" since "ambiguous-member-template" warning is a false-positive now. - Disable "ambiguous-member-template" diagnostic in 98 and 03 modes - Add an example (`struct A`) - Apply clang-format Reposit

[PATCH] D142315: [clang] Add test for CWG1111

Endill added inline comments. Comment at: clang/test/CXX/drs/dr11xx.cpp:31 + } +} + erichkeane wrote: > Can you also add the last example (with struct A) from the issue, and find a > way to confirm that it is calling the right version? Nice catch, thank you. Lo

[PATCH] D142315: [clang] Add test for CWG1111

Endill added a comment. In D142315#4073782 , @erichkeane wrote: > I didn't internalize that it was 'just a warning' (it was a -error in the > test above), we should have a task for someone to remove that warning as it > is no longer ambiguous. But I d

[PATCH] D142315: [clang] Add test for CWG1111

erichkeane added a comment. I didn't internalize that it was 'just a warning' (it was a -error in the test above), we should have a task for someone to remove that warning as it is no longer ambiguous. But I don't think it makes it 'partial' here anymore. Comment at: clang/t

[PATCH] D142315: [clang] Add test for CWG1111

Endill added inline comments. Comment at: clang/www/cxx_dr_status.html:6476 Remove dual-scope lookup of member template names -Unknown +Clang 6 shafik wrote: > aaron.ballman wrote: > > erichkeane wrote: > > > Were you able to track down which pat

[PATCH] D142315: [clang] Add test for CWG1111

shafik added inline comments. Comment at: clang/www/cxx_dr_status.html:6476 Remove dual-scope lookup of member template names -Unknown +Clang 6 aaron.ballman wrote: > erichkeane wrote: > > Were you able to track down which patch fixed this in cla

[PATCH] D142315: [clang] Add test for CWG1111

aaron.ballman added inline comments. Comment at: clang/www/cxx_dr_status.html:6476 Remove dual-scope lookup of member template names -Unknown +Clang 6 erichkeane wrote: > Were you able to track down which patch fixed this in clang 6? > > I also

[PATCH] D142315: [clang] Add test for CWG1111

erichkeane added inline comments. Comment at: clang/test/CXX/drs/dr11xx.cpp:31 + } +} + Can you also add the last example (with struct A) from the issue, and find a way to confirm that it is calling the right version? Comment at: clang/www/cx

[PATCH] D142315: [clang] Add test for CWG1111

Endill created this revision. Endill added a reviewer: clang-language-wg. Herald added a project: All. Endill requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D142315 Files: