[PATCH] D141581: [build] Fix stand-alone builds of clang.

fpetrogalli added a comment. Reverted in https://reviews.llvm.org/rG20ffb9aaf982 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141581/new/ https://reviews.llvm.org/D141581 ___ cfe-commits mailing list cf

[PATCH] D141581: [build] Fix stand-alone builds of clang.

tstellar added a comment. @fpetrogalli The solution is to add RISCVTargetParserTableGen to the Depnds list of clang/lib/Driver and clang/lib/Basic. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141581/new/ https://reviews.llvm.org/D141581 _

[PATCH] D141581: [build] Fix stand-alone builds of clang.

fpetrogalli added a comment. Ah - there you go. Without a proper chained dependency of LLVMTargetParser -> clangBasic we end up with failures if clangBasic is compiled before LLVMTargetParser is (even on non stand-alone builds). https://lab.llvm.org/buildbot/#/builders/193/builds/25362 : cca

[PATCH] D141581: [build] Fix stand-alone builds of clang.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG52bcdac3b842: [build] Fix stand-alone builds of clang. (authored by fpetrogalli). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D141581: [build] Fix stand-alone builds of clang.

tstellar added a comment. @fpetrogalli Please go ahead and push this since it is blocking others, we can fix up any of the other issues later. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141581/new/ https://reviews.llvm.org/D141581

[PATCH] D141581: [build] Fix stand-alone builds of clang.

fpetrogalli added a comment. In D141581#4074312 , @tstellar wrote: > I tested this patch and it works, so I'll give it an LGTM. However, I think > the LLVMConfig.cmake.in changes are now unnecessary since the > RISCVTargetParserTableGen has been dropp

[PATCH] D141581: [build] Fix stand-alone builds of clang.

fpetrogalli added inline comments. Comment at: clang/lib/Basic/CMakeLists.txt:113 omp_gen - RISCVTargetParserTableGen ) tstellar wrote: > Doesn't this break the monorepo (non-standalone) build? If the monorepo > build still works with this, then you don

[PATCH] D141581: [build] Fix stand-alone builds of clang.

tstellar accepted this revision. tstellar added a comment. This revision is now accepted and ready to land. I tested this patch and it works, so I'll give it an LGTM. However, I think the LLVMConfig.cmake.in changes are now unnecessary since the RISCVTargetParserTableGen has been dropped from

[PATCH] D141581: [build] Fix stand-alone builds of clang.

tstellar added inline comments. Comment at: clang/lib/Basic/CMakeLists.txt:113 omp_gen - RISCVTargetParserTableGen ) Doesn't this break the monorepo (non-standalone) build? If the monorepo build still works with this, then you don't need the changes to