[PATCH] D141543: [LinkerWrapper] Emit assembly files from LTO with `save-temps`

thakis added a comment. cb2f23a9b0de9c6747afb1efdc6e05b4691e0c50 did the trick. Thanks for the fix! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141543/new/ https://reviews.ll

[PATCH] D141543: [LinkerWrapper] Emit assembly files from LTO with `save-temps`

jhuber6 added a comment. In D141543#4050174 , @thakis wrote: > Thanks! Still failing with that though: > http://45.33.8.238/win/73278/step_7.txt Hm, I'm unsure what would be causing that. I could always just disable the test on Windows. This program is

[PATCH] D141543: [LinkerWrapper] Emit assembly files from LTO with `save-temps`

thakis added a comment. Thanks! Still failing with that though: http://45.33.8.238/win/73278/step_7.txt Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141543/new/ https://reviews.llvm.org/D141543 ___ cfe-

[PATCH] D141543: [LinkerWrapper] Emit assembly files from LTO with `save-temps`

jhuber6 added a comment. In D141543#4050080 , @thakis wrote: > Looks like this breaks tests on Windows: > http://45.33.8.238/win/73276/step_7.txt > > Please take a look and revert for now if it takes a while to fix. Yes, seems I forgot that `clang` is `

[PATCH] D141543: [LinkerWrapper] Emit assembly files from LTO with `save-temps`

thakis added a comment. Looks like this breaks tests on Windows: http://45.33.8.238/win/73276/step_7.txt Please take a look and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141543/new/ https://reviews.ll

[PATCH] D141543: [LinkerWrapper] Emit assembly files from LTO with `save-temps`

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9e239fc487d5: [LinkerWrapper] Emit assembly files from LTO with `save-temps` (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES S

[PATCH] D141543: [LinkerWrapper] Emit assembly files from LTO with `save-temps`

arsenm accepted this revision. arsenm added a comment. This revision is now accepted and ready to land. Thanks, maybe I'll actually be able to comprehend openmp now Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141543/new/ https://reviews.llvm.org/

[PATCH] D141543: [LinkerWrapper] Emit assembly files from LTO with `save-temps`

jhuber6 updated this revision to Diff 488690. jhuber6 added a comment. Changing to initializer list. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141543/new/ https://reviews.llvm.org/D141543 Files: clang/test/Driver/linker-wrapper.c clang/too

[PATCH] D141543: [LinkerWrapper] Emit assembly files from LTO with `save-temps`

arsenm added inline comments. Comment at: clang/tools/clang-linker-wrapper/ClangLinkerWrapper.cpp:531-537 + CmdArgs.push_back(*ClangPath); + CmdArgs.push_back("-o"); + CmdArgs.push_back(*TempFileOrErr); + CmdArgs.push_back("-fPIC"); + CmdArgs.push_back("-c"); + CmdArgs.push

[PATCH] D141543: [LinkerWrapper] Emit assembly files from LTO with `save-temps`

jhuber6 updated this revision to Diff 488679. jhuber6 added a comment. Fix test, should be good to go now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141543/new/ https://reviews.llvm.org/D141543 Files: clang/test/Driver/linker-wrapper.c cla

[PATCH] D141543: [LinkerWrapper] Emit assembly files from LTO with `save-temps`

jhuber6 added inline comments. Comment at: clang/tools/clang-linker-wrapper/ClangLinkerWrapper.cpp:531-537 + CmdArgs.push_back(*ClangPath); + CmdArgs.push_back("-o"); + CmdArgs.push_back(*TempFileOrErr); + CmdArgs.push_back("-fPIC"); + CmdArgs.push_back("-c"); + CmdArgs.pus

[PATCH] D141543: [LinkerWrapper] Emit assembly files from LTO with `save-temps`

jhuber6 updated this revision to Diff 488361. jhuber6 added a comment. Herald added a subscriber: sstefan1. Add test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141543/new/ https://reviews.llvm.org/D141543 Files: clang/test/Driver/linker-wrap

[PATCH] D141543: [LinkerWrapper] Emit assembly files from LTO with `save-temps`

arsenm added a comment. Missing test? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141543/new/ https://reviews.llvm.org/D141543 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm

[PATCH] D141543: [LinkerWrapper] Emit assembly files from LTO with `save-temps`

arsenm added inline comments. Comment at: clang/tools/clang-linker-wrapper/ClangLinkerWrapper.cpp:531-537 + CmdArgs.push_back(*ClangPath); + CmdArgs.push_back("-o"); + CmdArgs.push_back(*TempFileOrErr); + CmdArgs.push_back("-fPIC"); + CmdArgs.push_back("-c"); + CmdArgs.push

[PATCH] D141543: [LinkerWrapper] Emit assembly files from LTO with `save-temps`

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, JonChesterfield, arsenm, tianshilei1992. Herald added a subscriber: inglorion. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, wdng. Herald added a project: clang. Curr