[PATCH] D141463: [clang-tidy] Improve rename_check.py

ccotter marked an inline comment as done. ccotter added a comment. Thanks for reviewing and merging my recent changes! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141463/new/ https://reviews.llvm.org/D141463 _

[PATCH] D141463: [clang-tidy] Improve rename_check.py

This revision was automatically updated to reflect the committed changes. Closed by commit rG7718422d3b78: [clang-tidy] Improve rename_check.py (authored by ccotter, committed by carlosgalvezp). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141463/ne

[PATCH] D141463: [clang-tidy] Improve rename_check.py

njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/rename_check.py:75 print("Renaming '%s' -> '%s'..." % (fileName, newFileName)) - os.rename(fileName, newFileName) + subprocess.check_call(["git", "mv", fileName, newFileName]) return newFileName

[PATCH] D141463: [clang-tidy] Improve rename_check.py

carlosgalvezp accepted this revision. carlosgalvezp added a comment. This revision is now accepted and ready to land. LGTM, thanks for the fix! Let's give a few days for other reviewers to get a look. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[PATCH] D141463: [clang-tidy] Improve rename_check.py

ccotter marked an inline comment as done. ccotter added inline comments. Comment at: clang-tools-extra/clang-tidy/rename_check.py:75 print("Renaming '%s' -> '%s'..." % (fileName, newFileName)) - os.rename(fileName, newFileName) + subprocess.check_call(["git", "mv", fileName,

[PATCH] D141463: [clang-tidy] Improve rename_check.py

ccotter updated this revision to Diff 488169. ccotter added a comment. - revert git changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141463/new/ https://reviews.llvm.org/D141463 Files: clang-tools-extra/clang-tidy/rename_check.py Index: c

[PATCH] D141463: [clang-tidy] Improve rename_check.py

carlosgalvezp added inline comments. Comment at: clang-tools-extra/clang-tidy/rename_check.py:97 def getListOfFiles(clang_tidy_path): - files = glob.glob(os.path.join(clang_tidy_path, '*')) - for dirname in files: -if os.path.isdir(dirname): - files += glob.glob(os.pa

[PATCH] D141463: [clang-tidy] Improve rename_check.py

ccotter added inline comments. Comment at: clang-tools-extra/clang-tidy/rename_check.py:97 def getListOfFiles(clang_tidy_path): - files = glob.glob(os.path.join(clang_tidy_path, '*')) - for dirname in files: -if os.path.isdir(dirname): - files += glob.glob(os.path.joi

[PATCH] D141463: [clang-tidy] Improve rename_check.py

carlosgalvezp added a comment. Thanks for the fix! Some minor comments/questions. Comment at: clang-tools-extra/clang-tidy/rename_check.py:75 print("Renaming '%s' -> '%s'..." % (fileName, newFileName)) - os.rename(fileName, newFileName) + subprocess.check_call(["git", "mv"

[PATCH] D141463: [clang-tidy] Improve rename_check.py

ccotter added a comment. I tested with https://reviews.llvm.org/D141133 where I renamed my new check, but noticed rename_tool.py did not rename or update the check name in the test file. The result of running the updated script against my tool is on github: https://github.com/ccotter/llvm-proje

[PATCH] D141463: [clang-tidy] Improve rename_check.py

ccotter created this revision. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. ccotter requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. rename_check.py now find