[PATCH] D140756: Add clang_CXXMethod_isExplicit to libclang

aaron.ballman added a comment. In D140756#4128729 , @diseraluca wrote: > In D140756#4100387 , @aaron.ballman > wrote: > >> @diseraluca -- do you need this cherry picked into Clang 16 or are you fine >> if this

[PATCH] D140756: Add clang_CXXMethod_isExplicit to libclang

diseraluca added a comment. In D140756#4100387 , @aaron.ballman wrote: > @diseraluca -- do you need this cherry picked into Clang 16 or are you fine > if this goes into Clang 17 instead? Sorry for checking in so late, I noticed the notifications only n

[PATCH] D140756: Add clang_CXXMethod_isExplicit to libclang

aaron.ballman added a comment. In D140756#4115979 , @aaron.ballman wrote: > In D140756#4115963 , @vedgy wrote: > >> In D140756#4115381 , >> @aaron.ballman wrote: >> >>>

[PATCH] D140756: Add clang_CXXMethod_isExplicit to libclang

aaron.ballman added a comment. In D140756#4115963 , @vedgy wrote: > In D140756#4115381 , @aaron.ballman > wrote: > >> The spare moment came sooner than expected, I've made the changes in >> de4321cf2cf28f2bae7fc

[PATCH] D140756: Add clang_CXXMethod_isExplicit to libclang

vedgy added a comment. In D140756#4115381 , @aaron.ballman wrote: > The spare moment came sooner than expected, I've made the changes in > de4321cf2cf28f2bae7fc0f1897957e73b726f89 > .

[PATCH] D140756: Add clang_CXXMethod_isExplicit to libclang

aaron.ballman added a comment. In D140756#4115363 , @aaron.ballman wrote: > In D140756#4100387 , @aaron.ballman > wrote: > >> @diseraluca -- do you need this cherry picked into Clang 16 or are you fine >> if th

[PATCH] D140756: Add clang_CXXMethod_isExplicit to libclang

aaron.ballman added a comment. In D140756#4100387 , @aaron.ballman wrote: > @diseraluca -- do you need this cherry picked into Clang 16 or are you fine > if this goes into Clang 17 instead? I'll go with the assumption this is fine going into Clang 17 a

[PATCH] D140756: Add clang_CXXMethod_isExplicit to libclang

vedgy added a comment. The added, then reverted release note was lost when this revision landed the second time. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140756/new/ https://reviews.llvm.org/D140756 __

[PATCH] D140756: Add clang_CXXMethod_isExplicit to libclang

aaron.ballman added a comment. @diseraluca -- do you need this cherry picked into Clang 16 or are you fine if this goes into Clang 17 instead? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140756/new/ https://reviews.llvm.org/D140756

[PATCH] D140756: Add clang_CXXMethod_isExplicit to libclang

vedgy added inline comments. Comment at: clang/tools/libclang/libclang.map:419 clang_getSymbolGraphForUSR; +clang_CXXMethod_isExplicit; }; This line should be moved from under the `LLVM_16` tag to under a new `LLVM_17` tag. Alternatively this commit ca

[PATCH] D140756: Add clang_CXXMethod_isExplicit to libclang

aaron.ballman added a comment. In D140756#4099593 , @vedgy wrote: > I meant that the commit message of > https://reviews.llvm.org/rG79571aa2103c95760a07e3549d8636379e4948f0 > misleadingly refers to this review's commit. But `CINDEX_VERSION_MINOR == 63`

[PATCH] D140756: Add clang_CXXMethod_isExplicit to libclang

vedgy added a comment. I meant that the commit message of https://reviews.llvm.org/rG79571aa2103c95760a07e3549d8636379e4948f0 misleadingly refers to this review's commit. But `CINDEX_VERSION_MINOR == 63` is for previous commits. This commit will require incrementing `CINDEX_VERSION_MINOR` agai

[PATCH] D140756: Add clang_CXXMethod_isExplicit to libclang

aaron.ballman added a comment. In D140756#4099558 , @vedgy wrote: >> 79571aa2103c95760a07e3549d8636379e4948f0 >> is the >> commit on main and https://github.com/llvm/llvm-project/issu

[PATCH] D140756: Add clang_CXXMethod_isExplicit to libclang

vedgy added a comment. > 79571aa2103c95760a07e3549d8636379e4948f0 > is the > commit on main and https://github.com/llvm/llvm-project/issues/60478 is for > the 16.x cherry-pick. Thank you Aaron! But note that this review's co

[PATCH] D140756: Add clang_CXXMethod_isExplicit to libclang

aaron.ballman added a comment. In D140756#4099410 , @aaron.ballman wrote: > In D140756#4099326 , @vedgy wrote: > >> Hello Luca and Aaron. >> I have noticed that you recently implemented/reviewed multiple interest

[PATCH] D140756: Add clang_CXXMethod_isExplicit to libclang

aaron.ballman added a comment. In D140756#4099326 , @vedgy wrote: > Hello Luca and Aaron. > I have noticed that you recently implemented/reviewed multiple interesting > libclang features, some of which can be used in KDevelop. However, > `CINDEX_VERSION

[PATCH] D140756: Add clang_CXXMethod_isExplicit to libclang

vedgy added a comment. Hello Luca and Aaron. I have noticed that you recently implemented/reviewed multiple interesting libclang features, some of which can be used in KDevelop. However, `CINDEX_VERSION_MINOR` was last modified in Clang 13. This constant's documentation states: > `CINDEX_VERSI

[PATCH] D140756: Add clang_CXXMethod_isExplicit to libclang

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0a51bc731bcc: Add clang_CXXMethod_isExplicit to libclang (authored by Luca Di Sera ). Changed prior to commit: https://reviews.

[PATCH] D140756: Add clang_CXXMethod_isExplicit to libclang

aaron.ballman accepted this revision. aaron.ballman added a comment. The fixes LGTM, thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140756/new/ https://reviews.llvm.org/D140756 ___ cfe-commits

[PATCH] D140756: Add clang_CXXMethod_isExplicit to libclang

diseraluca updated this revision to Diff 492042. diseraluca added a comment. Fixed tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140756/new/ https://reviews.llvm.org/D140756 Files: clang/bindings/python/clang/cindex.py clang/bindings/pyt

[PATCH] D140756: Add clang_CXXMethod_isExplicit to libclang

diseraluca reopened this revision. diseraluca added a comment. This revision is now accepted and ready to land. When I pushed the patch the tests produced failures in buildbot. I reverted the patch as I did not have the time to check what was happening. I've now had time to check and the failure

[PATCH] D140756: Add clang_CXXMethod_isExplicit to libclang

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGddbe14084da7: Add clang_CXXMethod_isExplicit to libclang (authored by diseraluca). Changed prior to commit: https://reviews.llvm.org/D140756?vs=48

[PATCH] D140756: Add clang_CXXMethod_isExplicit to libclang

aaron.ballman added a comment. In D140756#4055516 , @diseraluca wrote: > In D140756#4051383 , @aaron.ballman > wrote: > >> LGTM aside from some minor things you can correct when landing. >> > > Thank you fo

[PATCH] D140756: Add clang_CXXMethod_isExplicit to libclang

diseraluca added a comment. In D140756#4051383 , @aaron.ballman wrote: > LGTM aside from some minor things you can correct when landing. > Thank you for the great suggestions! I'll try to correct it as soon as possible, hopefully this weekend. Sho

[PATCH] D140756: Add clang_CXXMethod_isExplicit to libclang

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from some minor things you can correct when landing. Comment at: clang/bindings/python/clang/cindex.py:1550-1557 +class Foo { +

[PATCH] D140756: Add clang_CXXMethod_isExplicit to libclang

diseraluca created this revision. diseraluca added a reviewer: aaron.ballman. Herald added a subscriber: arphaman. Herald added a project: All. diseraluca requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The new method is a wrapper of `CXXCo