aaron.ballman added a comment. In D140756#4055516 <https://reviews.llvm.org/D140756#4055516>, @diseraluca wrote:
> In D140756#4051383 <https://reviews.llvm.org/D140756#4051383>, @aaron.ballman > wrote: > >> LGTM aside from some minor things you can correct when landing. >> .... > > Thank you for the great suggestions! > > I'll try to correct it as soon as possible, hopefully this weekend. > Should I update the revision or should I just modify it and land it after > ensuring that it works correctly? Thanks for checking! Feel free to modify it and land it after ensuring it works correctly. :-) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140756/new/ https://reviews.llvm.org/D140756 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
