[PATCH] D139443: [AArch64] Support SLC in ACLE prefetch intrinsics

2022-12-16 Thread Sam Elliott via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. lenary marked 2 inline comments as done. Closed by commit rG82b51a142804: [AArch64] Support SLC in ACLE prefetch intrinsics (authored by lenary). Repository: rG LLVM

[PATCH] D139443: [AArch64] Support SLC in ACLE prefetch intrinsics

2022-12-16 Thread Lucas Prates via Phabricator via cfe-commits
pratlucas accepted this revision. pratlucas added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139443/new/ https://reviews.llvm.org/D139443

[PATCH] D139443: [AArch64] Support SLC in ACLE prefetch intrinsics

2022-12-13 Thread Jessica Paquette via Phabricator via cfe-commits
paquette added a comment. GISel part LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139443/new/ https://reviews.llvm.org/D139443 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.

[PATCH] D139443: [AArch64] Support SLC in ACLE prefetch intrinsics

2022-12-13 Thread Sam Elliott via Phabricator via cfe-commits
lenary added reviewers: paquette, aemerson. lenary added a comment. Adding Jessica and Amara as this affects GlobalISel for AArch64. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139443/new/ https://reviews.llvm.org/D139443 ___

[PATCH] D139443: [AArch64] Support SLC in ACLE prefetch intrinsics

2022-12-13 Thread Sam Elliott via Phabricator via cfe-commits
lenary updated this revision to Diff 482489. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139443/new/ https://reviews.llvm.org/D139443 Files: clang/lib/CodeGen/CGBuiltin.cpp clang/lib/Sema/SemaChecking.cpp clang/test/CodeGen/arm_acle.c clan

[PATCH] D139443: [AArch64] Support SLC in ACLE prefetch intrinsics

2022-12-06 Thread Thorsten via Phabricator via cfe-commits
tschuett added inline comments. Comment at: llvm/test/CodeGen/AArch64/arm64-prefetch-new.ll:2 +; RUN: llc -mtriple=aarch64 -mattr=+v8.9a < %s | FileCheck %s +; RUN: llc -mtriple=aarch64 -mattr=+v8.9a -O0 --global-isel-abort=1 < %s | FileCheck %s + lenary wrote:

[PATCH] D139443: [AArch64] Support SLC in ACLE prefetch intrinsics

2022-12-06 Thread Sam Elliott via Phabricator via cfe-commits
lenary added inline comments. Comment at: llvm/test/CodeGen/AArch64/arm64-prefetch-new.ll:2 +; RUN: llc -mtriple=aarch64 -mattr=+v8.9a < %s | FileCheck %s +; RUN: llc -mtriple=aarch64 -mattr=+v8.9a -O0 --global-isel-abort=1 < %s | FileCheck %s + tschuett wrote:

[PATCH] D139443: [AArch64] Support SLC in ACLE prefetch intrinsics

2022-12-06 Thread Thorsten via Phabricator via cfe-commits
tschuett added inline comments. Comment at: llvm/test/CodeGen/AArch64/arm64-prefetch-new.ll:2 +; RUN: llc -mtriple=aarch64 -mattr=+v8.9a < %s | FileCheck %s +; RUN: llc -mtriple=aarch64 -mattr=+v8.9a -O0 --global-isel-abort=1 < %s | FileCheck %s + I believe you

[PATCH] D139443: [AArch64] Support SLC in ACLE prefetch intrinsics

2022-12-06 Thread Sam Elliott via Phabricator via cfe-commits
lenary added a reviewer: sdesmalen. lenary added a subscriber: sdesmalen. lenary added a comment. @sdesmalen adding you as I've moved around the custom lowering of `INTRINSIC_VOID` to be its own function, and as we need to handle it for `@llvm.arm.prefetch` all the time, it's no longer condition

[PATCH] D139443: [AArch64] Support SLC in ACLE prefetch intrinsics

2022-12-06 Thread Sam Elliott via Phabricator via cfe-commits
lenary created this revision. Herald added subscribers: hiraditya, kristof.beyls. Herald added a project: All. lenary requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. This change: - Modifies the ACLE code to allow the new