[PATCH] D139173: [clang] Add test for CWG600

This revision was automatically updated to reflect the committed changes. Closed by commit rG7e31d0723dbf: [clang] Add test for CWG600 (authored by Endill). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139173/new/ https://reviews.llvm.org/D139173

[PATCH] D139173: [clang] Add test for CWG600

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139173/new/ https://reviews.llvm.org/D139173 ___ cfe-commits mailing lis

[PATCH] D139173: [clang] Add test for CWG600

Endill updated this revision to Diff 479818. Endill added a comment. Add a comment per @shafik request CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139173/new/ https://reviews.llvm.org/D139173 Files: clang/test/CXX/drs/dr6xx.cpp clang/www/cxx_dr_status.html Index: clang/www/cxx_

[PATCH] D139173: [clang] Add test for CWG600

shafik added inline comments. Comment at: clang/test/CXX/drs/dr6xx.cpp:18 + sp->f(2); + sp->f(2.2); // expected-error {{is a private member}} +} Endill wrote: > aaron.ballman wrote: > > Endill wrote: > > > Endill wrote: > > > > shafik wrote: > > > > > Maybe add

[PATCH] D139173: [clang] Add test for CWG600

Endill added inline comments. Comment at: clang/test/CXX/drs/dr6xx.cpp:18 + sp->f(2); + sp->f(2.2); // expected-error {{is a private member}} +} aaron.ballman wrote: > Endill wrote: > > Endill wrote: > > > shafik wrote: > > > > Maybe add a comment above this sa

[PATCH] D139173: [clang] Add test for CWG600

aaron.ballman added inline comments. Comment at: clang/test/CXX/drs/dr6xx.cpp:18 + sp->f(2); + sp->f(2.2); // expected-error {{is a private member}} +} Endill wrote: > Endill wrote: > > shafik wrote: > > > Maybe add a comment above this saying something like: >

[PATCH] D139173: [clang] Add test for CWG600

Endill added a subscriber: aaron.ballman. Endill added inline comments. Comment at: clang/test/CXX/drs/dr6xx.cpp:18 + sp->f(2); + sp->f(2.2); // expected-error {{is a private member}} +} Endill wrote: > shafik wrote: > > Maybe add a comment above this saying so

[PATCH] D139173: [clang] Add test for CWG600

Endill added inline comments. Comment at: clang/test/CXX/drs/dr6xx.cpp:18 + sp->f(2); + sp->f(2.2); // expected-error {{is a private member}} +} shafik wrote: > Maybe add a comment above this saying something like: > > ``` > // access control is applied after

[PATCH] D139173: [clang] Add test for CWG600

shafik added a comment. Thank you for updating the DR statuses! This is much appreciated. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139173/new/ https://reviews.llvm.org/D139173 ___ cfe-commits mailin

[PATCH] D139173: [clang] Add test for CWG600

shafik added inline comments. Comment at: clang/test/CXX/drs/dr6xx.cpp:18 + sp->f(2); + sp->f(2.2); // expected-error {{is a private member}} +} Maybe add a comment above this saying something like: ``` // access control is applied after overload resolution //

[PATCH] D139173: [clang] Add test for CWG600

Endill created this revision. Endill added a reviewer: clang-language-wg. Herald added a project: All. Endill requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. P1787 : //CWG600 is resolved by explaining that a