[PATCH] D138822: [clang] Add test for CWG36

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf5993fc7757e: [clang] Add test for CWG36 (authored by Endill). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D138822: [clang] Add test for CWG36

erichkeane accepted this revision. erichkeane added inline comments. Comment at: clang/test/CXX/drs/dr0xx.cpp:489 + +using B::i; // expected-error {{redeclaration of using declaration}} +using C::i; // expected-error {{redeclaration of using declaration}}

[PATCH] D138822: [clang] Add test for CWG36

aaron.ballman added inline comments. Comment at: clang/test/CXX/drs/dr0xx.cpp:489 + +using B::i; // expected-error {{redeclaration of using declaration}} +using C::i; // expected-error {{redeclaration of using declaration}} Endill wrote: > aaron.ballman w

[PATCH] D138822: [clang] Add test for CWG36

Endill added inline comments. Comment at: clang/test/CXX/drs/dr0xx.cpp:489 + +using B::i; // expected-error {{redeclaration of using declaration}} +using C::i; // expected-error {{redeclaration of using declaration}} aaron.ballman wrote: > Endill wrote: >

[PATCH] D138822: [clang] Add test for CWG36

aaron.ballman added inline comments. Comment at: clang/test/CXX/drs/dr0xx.cpp:489 + +using B::i; // expected-error {{redeclaration of using declaration}} +using C::i; // expected-error {{redeclaration of using declaration}} Endill wrote: > erichkeane wrot

[PATCH] D138822: [clang] Add test for CWG36

Endill added inline comments. Comment at: clang/test/CXX/drs/dr0xx.cpp:489 + +using B::i; // expected-error {{redeclaration of using declaration}} +using C::i; // expected-error {{redeclaration of using declaration}} erichkeane wrote: > Endill wrote: > >

[PATCH] D138822: [clang] Add test for CWG36

Endill updated this revision to Diff 478878. Endill added a comment. Get rid of unwanted changes supposedly cause by `arc diff` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138822/new/ https://reviews.llvm.org/D138822 Files: clang/test/CXX/drs/dr0xx.cpp clang/www/cxx_dr_status.htm

[PATCH] D138822: [clang] Add test for CWG36

Endill updated this revision to Diff 478875. Endill added a comment. Add examples with dependent types, and rearrange using declarations to group errors and notes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138822/new/ https://reviews.llvm.org/

[PATCH] D138822: [clang] Add test for CWG36

erichkeane added inline comments. Comment at: clang/test/CXX/drs/dr0xx.cpp:489 + +using B::i; // expected-error {{redeclaration of using declaration}} +using C::i; // expected-error {{redeclaration of using declaration}} Endill wrote: > erichkeane wrote:

[PATCH] D138822: [clang] Add test for CWG36

Endill added inline comments. Comment at: clang/test/CXX/drs/dr0xx.cpp:489 + +using B::i; // expected-error {{redeclaration of using declaration}} +using C::i; // expected-error {{redeclaration of using declaration}} erichkeane wrote: > As a nit, I prefer

[PATCH] D138822: [clang] Add test for CWG36

Endill added a comment. Discord feels perfect to me for this kind of questions. What's left is to get past a broken bot for agreeing with code of conduct. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138822/new/ https://reviews.llvm.org/D138822 ___

[PATCH] D138822: [clang] Add test for CWG36

erichkeane added inline comments. Comment at: clang/test/CXX/drs/dr0xx.cpp:489 + +using B::i; // expected-error {{redeclaration of using declaration}} +using C::i; // expected-error {{redeclaration of using declaration}} As a nit, I prefer the 'notes' to

[PATCH] D138822: [clang] Add test for CWG36

aaron.ballman added a comment. In D138822#3957503 , @Endill wrote: > Thank you! > >> FWIW, if you need help getting references from the mailing list or the wiki, >> feel free to mention what you're after and one of us on the committee can >> see about t

[PATCH] D138822: [clang] Add test for CWG36

Endill added a comment. Thank you! > FWIW, if you need help getting references from the mailing list or the wiki, > feel free to mention what you're after and one of us on the committee can see > about tracking down the details. Do you mean creating an incomplete diff and asking here in the co

[PATCH] D138822: [clang] Add test for CWG36

aaron.ballman accepted this revision as: aaron.ballman. aaron.ballman added a comment. This revision is now accepted and ready to land. Adding my explicit LG, but just personally instead of for the language wg. If we don't hear from anyone else in the next 1-2 days, I'd say this is safe to land.

[PATCH] D138822: [clang] Add test for CWG36

aaron.ballman added a comment. In D138822#3957459 , @Endill wrote: > Among the worst parts of this paper are references to mailing list and EDG > wiki, which I don't have access to. But I still managed to dig everything up, > and ready to explain if req

[PATCH] D138822: [clang] Add test for CWG36

Endill added a comment. Among the worst parts of this paper are references to mailing list and EDG wiki, which I don't have access to. But I still managed to dig everything up, and ready to explain if requested. No tests were copied blindly from issues. CHANGES SINCE LAST ACTION https://revi

[PATCH] D138822: [clang] Add test for CWG36

aaron.ballman added a comment. In D138822#3957395 , @Endill wrote: > @aaron.ballman Following example of other DR tests, I was reluctant to add > relevant comments, e.g. wording. But I can provide it going forward or even > update this patch. No worrie

[PATCH] D138822: [clang] Add test for CWG36

Endill added a comment. @aaron.ballman Following example of other DR test, I was reluctant to add relevant comments, e.g. wording. But I can provide it going forward or even update this patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138822/new/ https://reviews.llvm.org/D138822

[PATCH] D138822: [clang] Add test for CWG36

shafik added inline comments. Comment at: clang/test/CXX/drs/dr0xx.cpp:454 + +namespace dr36 { // dr36: yes +namespace example1 { aaron.ballman wrote: > It took me a while to convince myself, but yes, I agree that Clang seems to > implement the DR. I had to go b

[PATCH] D138822: [clang] Add test for CWG36

aaron.ballman added a reviewer: hubert.reinterpretcast. aaron.ballman added a comment. Adding Hubert for his C++ conformance opinion. Comment at: clang/test/CXX/drs/dr0xx.cpp:454 + +namespace dr36 { // dr36: yes +namespace example1 { It took me a while to convi

[PATCH] D138822: [clang] Add test for CWG36

Endill updated this revision to Diff 478303. Endill added a comment. Incorporate D138835 (correctly this time around) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138822/new/ https://reviews.llvm.org/D138822 Files: clang/test/CXX/drs/dr0xx.cpp c

[PATCH] D138822: [clang] Add test for CWG36

Endill added a comment. Sorry, I messed up diff update CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138822/new/ https://reviews.llvm.org/D138822 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/l

[PATCH] D138822: [clang] Add test for CWG36

Endill updated this revision to Diff 478300. Endill added a comment. Incorporate D138835 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138822/new/ https://reviews.llvm.org/D138822 Files: clang/www/cxx_dr_status.html clang/www/make_cxx_dr_status I

[PATCH] D138822: [clang] Add test for CWG36

erichkeane added a comment. BTW, I suspect you're close enough to ask for commit rights, and I'd prefer to not have to commit too many things for you, so please go through this procedure: https://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access Repository: rG LLVM Github Monorepo

[PATCH] D138822: [clang] Add test for CWG36

aaron.ballman added a comment. In D138822#3954104 , @Endill wrote: > Sure, I'll update core issue list in a separate diff. Thanks! > I don't have commit rights, but I have a commit merged (just one). Does it > make me eligible for that? Not quite yet

[PATCH] D138822: [clang] Add test for CWG36

Endill added a comment. Sure, I'll update core issue list in a separate diff. I don't have commit rights, but I have a commit merged (just one). Does it make me eligible for that? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138822/new/ https://r

[PATCH] D138822: [clang] Add test for CWG36

cor3ntin added a comment. Could you make a separate pull request for updating the core issue list (I didn't know it had been updated recently)? Or, i think you could commit the update of the core issue list directly (do you have commit rights?) and then work on the DR. Repository: rG LLVM Gi

[PATCH] D138822: [clang] Add test for CWG36

Endill created this revision. Endill added a project: clang-language-wg. Herald added a project: All. Endill requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D138822 Files: c