[PATCH] D138675: [flang] Add -ffast-math and -Ofast

2023-01-28 Thread Tom Eccles via Phabricator via cfe-commits
tblah marked an inline comment as done. tblah added inline comments. Comment at: flang/test/Driver/fast_math.f90:59-62 +! Check that -ffast-math causes us to link to crtfastmath.o +! UNSUPPORTED: system-windows +! RUN: %flang -ffast-math -### %s -o %t 2>&1 \ +! RUN: | FileChe

[PATCH] D138675: [flang] Add -ffast-math and -Ofast

2023-01-27 Thread Usman Nadeem via Phabricator via cfe-commits
mnadeem added inline comments. Herald added a subscriber: sunshaoce. Comment at: flang/test/Driver/fast_math.f90:59-62 +! Check that -ffast-math causes us to link to crtfastmath.o +! UNSUPPORTED: system-windows +! RUN: %flang -ffast-math -### %s -o %t 2>&1 \ +! RUN: | FileChe

[PATCH] D138675: [flang] Add -ffast-math and -Ofast

2022-12-14 Thread Amy Kwan via Phabricator via cfe-commits
amyk added a comment. In D138675#3995282 , @probinson wrote: > See D139967 for why `UNSUPPORTED: powerpc` > didn't work. That patch will put it back, and also update the lit config so > the check will work now. Thank

[PATCH] D138675: [flang] Add -ffast-math and -Ofast

2022-12-14 Thread Tom Eccles via Phabricator via cfe-commits
tblah added a comment. In D138675#3995282 , @probinson wrote: > See D139967 for why `UNSUPPORTED: powerpc` > didn't work. That patch will put it back, and also update the lit config so > the check will work now. Thank

[PATCH] D138675: [flang] Add -ffast-math and -Ofast

2022-12-14 Thread Paul Robinson via Phabricator via cfe-commits
probinson added a comment. See D139967 for why `UNSUPPORTED: powerpc` didn't work. That patch will put it back, and also update the lit config so the check will work now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D138675: [flang] Add -ffast-math and -Ofast

2022-12-12 Thread Amy Kwan via Phabricator via cfe-commits
amyk added a comment. In D138675#3989997 , @tblah wrote: > In D138675#3989826 , @amyk wrote: > >> Thanks for the follow up patch! I tested the patch locally and also saw the >> buildbot results, and it doesn't ap

[PATCH] D138675: [flang] Add -ffast-math and -Ofast

2022-12-12 Thread Tom Eccles via Phabricator via cfe-commits
tblah added a comment. In D138675#3989826 , @amyk wrote: > Thanks for the follow up patch! I tested the patch locally and also saw the > buildbot results, and it doesn't appear like the follow up patch marked > `powerpc` as unsupported as the error stil

[PATCH] D138675: [flang] Add -ffast-math and -Ofast

2022-12-12 Thread Amy Kwan via Phabricator via cfe-commits
amyk added a comment. In D138675#3989634 , @tblah wrote: > In D138675#3989403 , @amyk wrote: > >> Hi, >> >> The ppc64le-flang-rhel-clang >> bot is also experiencing s

[PATCH] D138675: [flang] Add -ffast-math and -Ofast

2022-12-12 Thread Tom Eccles via Phabricator via cfe-commits
tblah added a comment. In D138675#3989403 , @amyk wrote: > Hi, > > The ppc64le-flang-rhel-clang > bot is also experiencing some failures with the `Driver/fast_math.f90` test > case. In particular, `crtfastma

[PATCH] D138675: [flang] Add -ffast-math and -Ofast

2022-12-12 Thread Amy Kwan via Phabricator via cfe-commits
amyk added a comment. Hi, The ppc64le-flang-rhel-clang bot is also experiencing some failures with the `Driver/fast_math.f90` test case. In particular, `crtfastmath.o` is not found at all for `CHECK-CRT` as we can see in the failure details

[PATCH] D138675: [flang] Add -ffast-math and -Ofast

2022-12-12 Thread Valentin Clement via Phabricator via cfe-commits
clementval added a comment. In D138675#3988110 , @tblah wrote: > In D138675#3987836 , @clementval > wrote: > >> I have the `Driver/fast_math.f90` failing on my side. >> >> llvm-project/flang/test/Driver/fast_ma

[PATCH] D138675: [flang] Add -ffast-math and -Ofast

2022-12-12 Thread Tom Eccles via Phabricator via cfe-commits
tblah added a comment. In D138675#3987836 , @clementval wrote: > I have the `Driver/fast_math.f90` failing on my side. > > llvm-project/flang/test/Driver/fast_math.f90:63:14: error: CHECK-CRT: > expected string not found in input > ! CHECK-CRT: crtb

[PATCH] D138675: [flang] Add -ffast-math and -Ofast

2022-12-12 Thread Valentin Clement via Phabricator via cfe-commits
clementval added a comment. Herald added a subscriber: jdoerfert. I have the `Driver/fast_math.f90` failing on my side. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138675/new/ https://reviews.llvm.org/D138675

[PATCH] D138675: [flang] Add -ffast-math and -Ofast

2022-12-09 Thread Tom Eccles via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGe7b6660243d1: [flang] Add -ffast-math and -Ofast (authored by tblah). Herald added projects: clang, Flang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST