amyk added a comment.

In D138675#3989634 <https://reviews.llvm.org/D138675#3989634>, @tblah wrote:

> In D138675#3989403 <https://reviews.llvm.org/D138675#3989403>, @amyk wrote:
>
>> Hi,
>>
>> The ppc64le-flang-rhel-clang <https://lab.llvm.org/buildbot/#/builders/21> 
>> bot is also experiencing some failures with the `Driver/fast_math.f90` test 
>> case. In particular, `crtfastmath.o` is not found at all for `CHECK-CRT` as 
>> we can see in the failure details 
>> <https://lab.llvm.org/buildbot/#/builders/21/builds/57841/steps/6/logs/FAIL__Flang__fast_math_f90>.
>>
>>   llvm-project/flang/test/Driver/fast_math.f90:64:19: error: CHECK-CRT-SAME: 
>> expected string not found in input
>>   ! CHECK-CRT-SAME: crtfastmath.o
>>
>> The output for the `CHECK-CRT` line on the bot looks like the following:
>>
>>   
>> "/home/buildbots/ppc64le-flang-rhel-test/ppc64le-flang-rhel-clang-build/build/bin/flang-new"
>>  "-fc1" "-triple" "powerpc64le-unknown-linux-gnu" "-emit-obj" 
>> "-mrelocation-model" "pic" "-pic-level" "2" "-pic-is-pie" "-ffast-math" 
>> "-target-cpu" "ppc64le" "-o" "/tmp/lit-tmp-x_okwzug/fast_math-e9ab49.o" "-x" 
>> "f95-cpp-input" 
>> "/home/buildbots/ppc64le-flang-rhel-test/ppc64le-flang-rhel-clang-build/llvm-project/flang/test/Driver/fast_math.f90"
>>  
>>   
>>   "/usr/bin/ld" "-pie" "--hash-style=gnu" "--eh-frame-hdr" "-m" "elf64lppc" 
>> "-dynamic-linker" "/lib64/ld64.so.2" "-o" 
>> "/home/buildbots/ppc64le-flang-rhel-test/ppc64le-flang-rhel-clang-build/build/tools/flang/test/Driver/Output/fast_math.f90.tmp"
>>  "/usr/lib/gcc/ppc64le-redhat-linux/8/../../../../lib64/Scrt1.o" 
>> "/usr/lib/gcc/ppc64le-redhat-linux/8/../../../../lib64/crti.o" 
>> "/usr/lib/gcc/ppc64le-redhat-linux/8/crtbeginS.o" 
>> "-L/usr/lib/gcc/ppc64le-redhat-linux/8" 
>> "-L/usr/lib/gcc/ppc64le-redhat-linux/8/../../../../lib64" "-L/lib/../lib64" 
>> "-L/usr/lib/../lib64" "-L/lib" "-L/usr/lib" 
>> "/tmp/lit-tmp-x_okwzug/fast_math-e9ab49.o" "-lFortran_main" 
>> "-lFortranRuntime" "-lFortranDecimal" "-lm" "-lgcc" "--as-needed" "-lgcc_s" 
>> "--no-as-needed" "-lc" "-lgcc" "--as-needed" "-lgcc_s" "--no-as-needed" 
>> "/usr/lib/gcc/ppc64le-redhat-linux/8/crtendS.o" 
>> "/usr/lib/gcc/ppc64le-redhat-linux/8/../../../../lib64/crtn.o"               
>>                                                                          
>>
>> Would it be possible to follow up with a fix for this test case?
>
> Thanks for letting me know. I thought I had already disabled that test on 
> powerpc (in 
> https://github.com/llvm/llvm-project/commit/20cd3153f3775fcdc1eeeb54062849eead51e24a)
>  but apparently it didn't work. I don't have a powerpc system available to 
> test this. I have pushed a second attempt at 
> https://github.com/llvm/llvm-project/commit/6442b4da4e7018e8f264965768b9e4fdee393c8f.
>  Please let me know if that works.

Thanks for the follow up patch! I tested the patch locally and also saw the 
buildbot results, and it doesn't appear like the follow up patch marked 
`powerpc` as unsupported as the error still persists 
(https://lab.llvm.org/buildbot/#/builders/21/builds/57850). 
I was playing around with the test case locally and what appears to work is 
doing something like:

  ! UNSUPPORTED: powerpc-registered-target


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138675/new/

https://reviews.llvm.org/D138675

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to