[PATCH] D138425: [clangd] Parameter hints for template specialization

v1nh1shungry abandoned this revision. v1nh1shungry added a comment. Sorry for the delay. I'd say I was convinced and about to abandon this patch. Sincere apologies for wasting everyone's time. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138425/n

[PATCH] D138425: [clangd] Parameter hints for template specialization

nridge added a comment. FWIW, in codebases/components where I do code reviews, I tend to insist on template parameters having meaningful (and longer-than-one-character) names, and would find this quite useful. I agree that while template parameters are technically a kind of parameter, they're

[PATCH] D138425: [clangd] Parameter hints for template specialization

tom-anders added a comment. In D138425#3941206 , @sammccall wrote: > In D138425#3941183 , @v1nh1shungry > wrote: > >> Yes, there is a common situation where people use a meaningless template >> parameter name, b

[PATCH] D138425: [clangd] Parameter hints for template specialization

sammccall added a comment. In D138425#3941183 , @v1nh1shungry wrote: > @sammccall Thank you for reviewing and giving suggestions! > > I must admit I didn't use it for very long. But I do think this is helpful, > at least for templates I'm unfamiliar wit

[PATCH] D138425: [clangd] Parameter hints for template specialization

v1nh1shungry added a comment. @sammccall Thank you for reviewing and giving suggestions! I must admit I didn't use it for very long. But I do think this is helpful, at least for templates I'm unfamiliar with. Yes, there is a common situation where people use a meaningless template parameter na

[PATCH] D138425: [clangd] Parameter hints for template specialization

sammccall added a comment. The code looks pretty good and this makes a lot of logical sense. However, there's an ugly practical issue: it's overwhelmingly common for template parameters to have cryptic and useless names. It seems like turning `vector` into `vector` actually makes things worse.

[PATCH] D138425: [clangd] Parameter hints for template specialization

v1nh1shungry added a comment. This patch implements: - Template specialization type - Class template specialization declaration - Variable template specialization declaration - Function specialization declaration It would be sweet to also implement: template constexpr int value = 0; int

[PATCH] D138425: [clangd] Parameter hints for template specialization

v1nh1shungry created this revision. v1nh1shungry added reviewers: nridge, sammccall. Herald added subscribers: kadircet, arphaman. Herald added a project: All. v1nh1shungry requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clan