This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGf6c54cdbc439: [-Wunsafe-buffer-usage] Ignore array subscript
on literal zero (authored by ziqingluo-90).
Changed prior to commit:
https://reviews.
NoQ accepted this revision.
NoQ added a comment.
This revision is now accepted and ready to land.
LGTM!
Comment at: clang/lib/Analysis/UnsafeBufferUsage.cpp:219
+arraySubscriptExpr(hasBase(ignoringParenImpCasts(hasPointerType())),
+ unless(hasI
xazax.hun added inline comments.
Comment at: clang/lib/Analysis/UnsafeBufferUsage.cpp:219
+arraySubscriptExpr(hasBase(ignoringParenImpCasts(hasPointerType())),
+ unless(hasIndex(integerLiteral(equals(0)
.bind("arraySubscr"));
---
ziqingluo-90 updated this revision to Diff 476581.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D138321/new/
https://reviews.llvm.org/D138321
Files:
clang/lib/Analysis/UnsafeBufferUsage.cpp
clang/test/SemaCXX/warn-unsafe-buffer-usage.cpp
Index: clang/test/SemaCXX/warn-unsafe-buffer
ziqingluo-90 created this revision.
ziqingluo-90 added reviewers: NoQ, jkorous, t-rasmud, malavikasamak,
aaron.ballman, gribozavr, xazax.hun.
Herald added a subscriber: rnkovacs.
Herald added a project: All.
ziqingluo-90 requested review of this revision.
Herald added a project: clang.
Herald adde