xazax.hun added inline comments.
================
Comment at: clang/lib/Analysis/UnsafeBufferUsage.cpp:219
+ arraySubscriptExpr(hasBase(ignoringParenImpCasts(hasPointerType())),
+ unless(hasIndex(integerLiteral(equals(0)))))
.bind("arraySubscr"));
----------------
Isn't it the case you still want to cover zero indices but as a safe gadget to
make sure fixits can be emitted?
Having to add another gadget for this makes me think maybe categorizing the
safety of gadgets upfront is not the right model.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D138321/new/
https://reviews.llvm.org/D138321
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
