[PATCH] D138200: [include-cleaner] Make use of locateSymbol in WalkUsed

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG29a8eec1f9eb: [include-cleaner] Make use of locateSymbol in WalkUsed and HTMLReport (authored by kadircet). Repository: rG LLVM Github Monorepo C

[PATCH] D138200: [include-cleaner] Make use of locateSymbol in WalkUsed

kadircet updated this revision to Diff 480454. kadircet marked an inline comment as done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138200/new/ https://reviews.llvm.org/D138200 Files: clang-tools-

[PATCH] D138200: [include-cleaner] Make use of locateSymbol in WalkUsed

kadircet marked 2 inline comments as done. kadircet added inline comments. Comment at: clang-tools-extra/include-cleaner/test/multiple-providers.cpp:1 +// RUN: clang-include-cleaner --print=changes %s -- -I %S/Inputs | FileCheck \ +// RUN: --allow-empty %s sammcc

[PATCH] D138200: [include-cleaner] Make use of locateSymbol in WalkUsed

sammccall accepted this revision. sammccall added a comment. LG, thanks! Comment at: clang-tools-extra/include-cleaner/lib/Analysis.cpp:33 + for (auto &Loc : locateSymbol(S)) +// FIXME: findHeaders in theory returns the same result for all source +// locations in the s

[PATCH] D138200: [include-cleaner] Make use of locateSymbol in WalkUsed

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. looks good from my side. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138200/new/ https://reviews.llvm.org/D138200 ___

[PATCH] D138200: [include-cleaner] Make use of locateSymbol in WalkUsed

kadircet updated this revision to Diff 480420. kadircet added a comment. - Fix RUN: line in lit test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138200/new/ https://reviews.llvm.org/D138200 Files: clang-tools-extra/include-cleaner/lib/Analysis

[PATCH] D138200: [include-cleaner] Make use of locateSymbol in WalkUsed

kadircet updated this revision to Diff 480419. kadircet marked an inline comment as done. kadircet added a comment. - Drop the cache - Use `-print=changes` in lit test - Update unittest helper to limit decls to main file Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[PATCH] D138200: [include-cleaner] Make use of locateSymbol in WalkUsed

kadircet marked 5 inline comments as done. kadircet added inline comments. Comment at: clang-tools-extra/include-cleaner/test/html.cpp:7 int n = foo(); +// CHECK: Symbol{{.*}}foo +// CHECK-NEXT: int foo() sammccall wrote: > I'd like to keep a very simple smoke t

[PATCH] D138200: [include-cleaner] Make use of locateSymbol in WalkUsed

sammccall added inline comments. Comment at: clang-tools-extra/include-cleaner/lib/Analysis.cpp:44 + + // Cache for decl to header mappings, as the same decl might be referenced in + // multiple locations and finding providers for each location is expensive. ka

[PATCH] D138200: [include-cleaner] Make use of locateSymbol in WalkUsed

kadircet added inline comments. Comment at: clang-tools-extra/include-cleaner/lib/Analysis.cpp:44 + + // Cache for decl to header mappings, as the same decl might be referenced in + // multiple locations and finding providers for each location is expensive. hok

[PATCH] D138200: [include-cleaner] Make use of locateSymbol in WalkUsed

kadircet updated this revision to Diff 480340. kadircet marked 3 inline comments as done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138200/new/ https://reviews.llvm.org/D138200 Files: clang-tools-

[PATCH] D138200: [include-cleaner] Make use of locateSymbol in WalkUsed

hokein added a comment. sorry for the delay, just realize it is sitting in the review list, left some comments. Comment at: clang-tools-extra/include-cleaner/lib/Analysis.cpp:25 +// Gets all the providers for a symbol by tarversing each location. +llvm::SmallVector findAllHead

[PATCH] D138200: [include-cleaner] Make use of locateSymbol in WalkUsed

kadircet updated this revision to Diff 478614. kadircet added a comment. - Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138200/new/ https://reviews.llvm.org/D138200 Files: clang-tools-extra/include-cleaner/lib/Analysis.cpp clang-tools-

[PATCH] D138200: [include-cleaner] Make use of locateSymbol in WalkUsed

kadircet created this revision. kadircet added reviewers: hokein, sammccall. Herald added a project: All. kadircet requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Depens on D135953 Repository