[PATCH] D138081: [IR] Split out IR printing passes into IRPrinter

alexander-shaposhnikov added inline comments. Comment at: utils/bazel/llvm-project-overlay/llvm/BUILD.bazel:918 ":Core", +":IRPrinter", ":IRReader", tejohnson wrote: > Per the follow on fix to D137768, I guess this one was unnecessary. C

[PATCH] D138081: [IR] Split out IR printing passes into IRPrinter

tejohnson added inline comments. Comment at: utils/bazel/llvm-project-overlay/llvm/BUILD.bazel:918 ":Core", +":IRPrinter", ":IRReader", Per the follow on fix to D137768, I guess this one was unnecessary. Can you check if there are any o

[PATCH] D138081: [IR] Split out IR printing passes into IRPrinter

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7059a6c32cfa: [IR] Split out IR printing passes into IRPrinter (authored by alexander-shaposhnikov). Changed prior to commit: https://reviews.llvm

[PATCH] D138081: [IR] Split out IR printing passes into IRPrinter

alexander-shaposhnikov added inline comments. Comment at: llvm/lib/IR/IRPrintingPasses.cpp:9 // // PrintModulePass and PrintFunctionPass implementations. // tejohnson wrote: > tejohnson wrote: > > Update comment > Please update this comment before committing,

[PATCH] D138081: [IR] Split out IR printing passes into IRPrinter

tejohnson accepted this revision. tejohnson added a comment. lgtm with one comment update still needed Comment at: llvm/lib/IR/IRPrintingPasses.cpp:9 // // PrintModulePass and PrintFunctionPass implementations. // tejohnson wrote: > Update comment Please upd

[PATCH] D138081: [IR] Split out IR printing passes into IRPrinter

alexander-shaposhnikov updated this revision to Diff 476208. alexander-shaposhnikov edited the summary of this revision. alexander-shaposhnikov added a comment. Update comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138081/new/ https://revie

[PATCH] D138081: [IR] Split out IR printing passes into IRPrinter

tejohnson added a comment. In D138081#3934386 , @MaskRay wrote: >> This diff splits out (from LLVMCore) IR printing passes into IRPrinter. > > I haven't spent too much time reading this patch. Is this to fix layering > check for `-module-summary/-flto=th

[PATCH] D138081: [IR] Split out IR printing passes into IRPrinter

MaskRay added a comment. > This diff splits out (from LLVMCore) IR printing passes into IRPrinter. I haven't spent too much time reading this patch. Is this to fix layering check for `-module-summary/-flto=thin with -S/-emit-llvm`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D138081: [IR] Split out IR printing passes into IRPrinter

tejohnson added a comment. In D138081#3931419 , @alexander-shaposhnikov wrote: > @tejohnson - the legacy pass manager depends on the interface defined in > IRPrintingPasses.h > (https://github.com/llvm/llvm-project/blob/main/llvm/lib/IR/LegacyPassManag

[PATCH] D138081: [IR] Split out IR printing passes into IRPrinter

aeubanks added inline comments. Comment at: llvm/include/llvm/IRPrinter/IRPrintingPasses.h:33 +/// +/// Note: This pass is for use with the new pass manager. Use the create...Pass +/// functions above to create passes for use with the legacy pass manager. tejohns

[PATCH] D138081: [IR] Split out IR printing passes into IRPrinter

tejohnson added inline comments. Comment at: llvm/include/llvm/IRPrinter/IRPrintingPasses.h:33 +/// +/// Note: This pass is for use with the new pass manager. Use the create...Pass +/// functions above to create passes for use with the legacy pass manager. aeuban

[PATCH] D138081: [IR] Split out IR printing passes into IRPrinter

aeubanks accepted this revision. aeubanks added a comment. This revision is now accepted and ready to land. in the description, link to the change that makes this necessary and describe why (need to use an analysis in the pass) Comment at: llvm/include/llvm/IRPrinter/IRPrintin

[PATCH] D138081: [IR] Split out IR printing passes into IRPrinter

alexander-shaposhnikov added a comment. @tejohnson - the legacy pass manager depends on the interface defined in IRPrintingPasses.h (https://github.com/llvm/llvm-project/blob/main/llvm/lib/IR/LegacyPassManager.cpp#L266) so without splitting this would face the same issue - circular dependency b

[PATCH] D138081: [IR] Split out IR printing passes into IRPrinter

tejohnson added a comment. Why not just move IRPrintingPasses.{h,cpp} as is to the new directory, vs splitting up the legacy vs new pm handling into separate places? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138081/new/ https://reviews.llvm.or

[PATCH] D138081: [IR] Split out IR printing passes into IRPrinter

alexander-shaposhnikov created this revision. alexander-shaposhnikov added reviewers: nikic, aeubanks, tejohnson. alexander-shaposhnikov created this object with visibility "All Users". Herald added subscribers: Moerafaat, zero9178, bzcheeseman, sdasgup3, wenzhicui, wrengr, ormris, cota, teijeong,