This revision was automatically updated to reflect the committed changes.
Closed by commit rG87f652d31f6d: Migrate getOrCreateInternalVariable from Clang
to OMPIRBuilder. (authored by TIFitis).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D137720/new
TIFitis added inline comments.
Comment at: llvm/include/llvm/Frontend/OpenMP/OMPIRBuilder.h:1729
+ const llvm::StringRef &Name,
+ unsigned AddressSpace = 0);
};
jdoerfert w
TIFitis updated this revision to Diff 475125.
TIFitis marked 2 inline comments as done.
TIFitis added a comment.
Addressed comments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D137720/new/
https://reviews.llvm.org/D137720
Files:
clang/lib/Code
jdoerfert accepted this revision.
jdoerfert added a comment.
This revision is now accepted and ready to land.
LG, minor nits. Nice cleanup.
Comment at: llvm/include/llvm/Frontend/OpenMP/OMPIRBuilder.h:1729
+ const llvm::StringRef &Na
shafik added inline comments.
Comment at: llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp:3980
+Elem.second = new GlobalVariable(
+M, Ty, /*IsConstant*/ false, GlobalValue::CommonLinkage,
+Constant::getNullValue(Ty), Elem.first(),
Repository:
r
TIFitis updated this revision to Diff 474284.
TIFitis added a comment.
Fix commit message indentation.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D137720/new/
https://reviews.llvm.org/D137720
Files:
clang/lib/CodeGen/CGOpenMPRuntime.cpp
clan
TIFitis created this revision.
TIFitis added reviewers: jdoerfert, jsjodin.
Herald added a subscriber: hiraditya.
Herald added a project: All.
TIFitis requested review of this revision.
Herald added subscribers: llvm-commits, cfe-commits, sstefan1.
Herald added projects: clang, LLVM.
This patch re
