TIFitis added inline comments.
================ Comment at: llvm/include/llvm/Frontend/OpenMP/OMPIRBuilder.h:1729 + const llvm::StringRef &Name, + unsigned AddressSpace = 0); }; ---------------- jdoerfert wrote: > No `llvm::`. Can you check your future patches for these things, please. > StringRef is passed by value not reference. Sure. The current code was inconsistent so I wasn't sure and went with the standard practice of explicitly describing namespace in header files and removed them from cpp files. I'll remove from both going forward :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137720/new/ https://reviews.llvm.org/D137720 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
