[PATCH] D137652: Remove mandatory define of optional features macros for OpenCL C 3.0

FMarno added a comment. Thank you for your comments. Unfortunately I won't be able to implement these changes because of time constraints in the current project, sorry if I've wasted your time. On the bright side I feel like I've learned something so thank you for that. I hope I can make a prop

[PATCH] D137652: Remove mandatory define of optional features macros for OpenCL C 3.0

Anastasia added a comment. In D137652#3957519 , @svenvh wrote: >> @svenvh I remember that we have also discussed the addition of a vendor >> specific header where such feature/extension macro definition can be added >> to avoid the macro pollution but I

[PATCH] D137652: Remove mandatory define of optional features macros for OpenCL C 3.0

svenvh added a comment. > @svenvh I remember that we have also discussed the addition of a vendor > specific header where such feature/extension macro definition can be added to > avoid the macro pollution but I feel this is somewhat orthogonal i.e. the > fine grained control of macro defines i

[PATCH] D137652: Remove mandatory define of optional features macros for OpenCL C 3.0

Anastasia added a comment. In D137652#3957233 , @FMarno wrote: > @Anastasia I feel like I am following the guidance you quoted here. The > defines I've deleted in `opencl-c-base.h` are blocking the possibility of > `-cl-ext` working and would also get i

[PATCH] D137652: Remove mandatory define of optional features macros for OpenCL C 3.0

FMarno added a comment. @Anastasia I feel like I am following the guidance you quoted here. The defines I've deleted in `opencl-c-base.h` are blocking the possibility of `-cl-ext` working and would also get in the way of undefine preprocessor symbols working. If there is a problem with the addi

[PATCH] D137652: Remove mandatory define of optional features macros for OpenCL C 3.0

Anastasia added a comment. Are these features affecting the frontend functionality in any way? If not we should implement those in the headers and if headers are not flexible enough to condition out the addition of the new macros we should extend them (potentially by extending behaviour of `-cl

[PATCH] D137652: Remove mandatory define of optional features macros for OpenCL C 3.0

svenvh added inline comments. Comment at: clang/include/clang/Basic/OpenCLExtensions.def:123 +OPENCL_OPTIONALCOREFEATURE(__opencl_c_work_group_collective_functions, false, 300, OCL_C_30) +OPENCL_OPTIONALCOREFEATURE(__opencl_c_int64, false, 300, OCL_C_30) I am

[PATCH] D137652: Remove mandatory define of optional features macros for OpenCL C 3.0

FMarno created this revision. FMarno added a reviewer: Anastasia. Herald added subscribers: Naghasan, ldrumm, yaxunl. Herald added a project: All. FMarno requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. A number of feature macros were being