[PATCH] D137487: [clang][Interp] Start implementing builtin functions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. tbaeder marked an inline comment as done. Closed by commit rGa7a4463acbe1: [clang][Interp] Start implementing builtin functions (authored by tbaeder). Repository: rG

[PATCH] D137487: [clang][Interp] Start implementing builtin functions

tbaeder marked 2 inline comments as done. tbaeder added inline comments. Comment at: clang/lib/AST/Interp/Interp.h:1315 + if (InterpretBuiltin(S, PC, Func->getBuiltinID())) { +NewFrame.release(); +return true; shafik wrote: > We don't have to update `S.C

[PATCH] D137487: [clang][Interp] Start implementing builtin functions

shafik added inline comments. Comment at: clang/lib/AST/Interp/Interp.h:1315 + if (InterpretBuiltin(S, PC, Func->getBuiltinID())) { +NewFrame.release(); +return true; We don't have to update `S.Current`? Comment at: clang/lib/AST/Inter

[PATCH] D137487: [clang][Interp] Start implementing builtin functions

tbaeder updated this revision to Diff 479201. tbaeder added a comment. Split `CallBI` out from `Call`, so we don't need special cases in `CheckCallable` etc. for builtin functions. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137487/new/ https://reviews.llvm.org/D137487 Files: clan

[PATCH] D137487: [clang][Interp] Start implementing builtin functions

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/Interp.h:1357 +if (InterpretBuiltin(S, PC, BID)) { + NewFrame.release(); + return true; erichkeane wrote: > tbaeder wrote: > > erichkeane wrote: > > > What is going on here? Why is thi

[PATCH] D137487: [clang][Interp] Start implementing builtin functions

erichkeane added inline comments. Comment at: clang/lib/AST/Interp/Interp.h:1357 +if (InterpretBuiltin(S, PC, BID)) { + NewFrame.release(); + return true; tbaeder wrote: > erichkeane wrote: > > What is going on here? Why is this not a leak? > The

[PATCH] D137487: [clang][Interp] Start implementing builtin functions

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:1374 const Decl *Callee = E->getCalleeDecl(); - if (const auto *FuncDecl = dyn_cast_or_null(Callee)) { + if (const auto *FuncDecl = dyn_cast_if_present(Callee)) { const Function *Func =

[PATCH] D137487: [clang][Interp] Start implementing builtin functions

erichkeane added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:1374 const Decl *Callee = E->getCalleeDecl(); - if (const auto *FuncDecl = dyn_cast_or_null(Callee)) { + if (const auto *FuncDecl = dyn_cast_if_present(Callee)) { const Function *Func

[PATCH] D137487: [clang][Interp] Start implementing builtin functions

tbaeder added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137487/new/ https://reviews.llvm.org/D137487 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D137487: [clang][Interp] Start implementing builtin functions

tbaeder updated this revision to Diff 473443. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137487/new/ https://reviews.llvm.org/D137487 Files: clang/lib/AST/CMakeLists.txt clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/Function.h clang/lib/AST/Interp/Interp.cpp

[PATCH] D137487: [clang][Interp] Start implementing builtin functions

tschuett added inline comments. Comment at: clang/lib/AST/Interp/InterpBuiltin.cpp:14 +namespace clang { +namespace interp { + You are allowed to use nested namespaces. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D137487: [clang][Interp] Start implementing builtin functions

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, tahonermann, shafik. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Another try at this. This time, only implement `__