[PATCH] D137251: [clang][cuda/hip] Allow `__noinline__` lambdas

This revision was automatically updated to reflect the committed changes. Pierre-vh marked 3 inline comments as done. Closed by commit rGc05f1639f7f4: [clang][cuda/hip] Allow `__noinline__` lambdas (authored by Pierre-vh). Changed prior to commit: https://reviews.llvm.org/D137251?vs=472875&id=

[PATCH] D137251: [clang][cuda/hip] Allow `__noinline__` lambdas

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from some very minor nits. Comment at: clang/docs/ReleaseNotes.rst:618 + - Allow the use of `__noinline__` as a keyword (instead of `__attribute__

[PATCH] D137251: [clang][cuda/hip] Allow `__noinline__` lambdas

yaxunl added a comment. In D137251#3904618 , @Pierre-vh wrote: > Comments > > Not sure if the release note is in the right place though. > As for the test, I did something quite targeted/minimal, hope it's fine? LGTM. Thanks. Repository: rG LLVM Gith

[PATCH] D137251: [clang][cuda/hip] Allow `__noinline__` lambdas

yaxunl added inline comments. Comment at: clang/lib/Parse/ParseExprCXX.cpp:1300 +ParseGNUAttributes(Attr, nullptr, &D); + } else if (Tok.is(tok::kw___noinline__)) { +IdentifierInfo *AttrName = Tok.getIdentifierInfo(); Pierre-vh wrote: > aaron

[PATCH] D137251: [clang][cuda/hip] Allow `__noinline__` lambdas

Pierre-vh added inline comments. Comment at: clang/lib/Parse/ParseExprCXX.cpp:1300 +ParseGNUAttributes(Attr, nullptr, &D); + } else if (Tok.is(tok::kw___noinline__)) { +IdentifierInfo *AttrName = Tok.getIdentifierInfo(); aaron.ballman wrote:

[PATCH] D137251: [clang][cuda/hip] Allow `__noinline__` lambdas

Pierre-vh updated this revision to Diff 472875. Pierre-vh marked 2 inline comments as done. Pierre-vh added a comment. Comments Not sure if the release note is in the right place though. As for the test, I did something quite targeted/minimal, hope it's fine? Repository: rG LLVM Github Monore

[PATCH] D137251: [clang][cuda/hip] Allow `__noinline__` lambdas

rsmith added a comment. In D137251#3902835 , @tra wrote: > LGTM in principle. Please wait for @rsmith's OK. I'm happy to defer to @aaron.ballman on this :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137

[PATCH] D137251: [clang][cuda/hip] Allow `__noinline__` lambdas

aaron.ballman added a comment. Can you also add a release note for the fix? Comment at: clang/lib/Parse/ParseExprCXX.cpp:1300 +ParseGNUAttributes(Attr, nullptr, &D); + } else if (Tok.is(tok::kw___noinline__)) { +IdentifierInfo *AttrName = Tok.getIdentifierI

[PATCH] D137251: [clang][cuda/hip] Allow `__noinline__` lambdas

tra added a comment. LGTM in principle. Please wait for @rsmith's OK. Comment at: clang/lib/Parse/ParseExprCXX.cpp:1297-1308 +while (true) { + if (Tok.is(tok::kw___attribute)) { +ParseGNUAttributes(Attr, nullptr, &D); + } else if (Tok.is(tok::kw___noinline

[PATCH] D137251: [clang][cuda/hip] Allow `__noinline__` lambdas

yaxunl added a comment. need a CodeGenCUDA test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137251/new/ https://reviews.llvm.org/D137251 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://

[PATCH] D137251: [clang][cuda/hip] Allow `__noinline__` lambdas

Pierre-vh created this revision. Pierre-vh added reviewers: yaxunl, tra, aaron.ballman, rsmith. Herald added a subscriber: mattd. Herald added a project: All. Pierre-vh requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. D124866