yaxunl added inline comments.
================ Comment at: clang/lib/Parse/ParseExprCXX.cpp:1300 + ParseGNUAttributes(Attr, nullptr, &D); + } else if (Tok.is(tok::kw___noinline__)) { + IdentifierInfo *AttrName = Tok.getIdentifierInfo(); ---------------- Pierre-vh wrote: > aaron.ballman wrote: > > Any other keyword attributes that are missing? > > > > `alignas`/`_Alignas` > > `__forceinline` > > `__cdecl`/`__stdcall`/etc > > > I'm not too familiar with how those attributes work yet, so maybe there's > more to handle but I don't have any concrete example of it being an issue and > would rather not touch those unless needed CUDA only allows `__attribute__` for lambda. `__noinline__` used to be an attribute. That's why people use it with lambda. I don't think people use other keywords with lambda. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137251/new/ https://reviews.llvm.org/D137251 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits