[PATCH] D136723: [include-cleaner] Record main-file macro occurences and includes

kadircet added a comment. In D136723#3915898 , @sammccall wrote: > (and sorry, it seems I was sitting on a pile of comments I thought I'd sent, > LMK if I should follow up on them) no looks good. the only meaty discussion was fileentry to multiple incl

[PATCH] D136723: [include-cleaner] Record main-file macro occurences and includes

sammccall added a comment. (and sorry, it seems I was sitting on a pile of comments I thought I'd sent, LMK if I should follow up on them) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136723/new/ https://reviews.llvm.org/D136723

[PATCH] D136723: [include-cleaner] Record main-file macro occurences and includes

sammccall added a comment. In D136723#3915853 , @maryammo wrote: > This commit causes build failure on > `https://lab.llvm.org/buildbot/#/builders/121/builds/24947` : > I was able to reproduce the failure and by reverting this commit locally it > pas

[PATCH] D136723: [include-cleaner] Record main-file macro occurences and includes

maryammo added a comment. This commit causes build failure on `https://lab.llvm.org/buildbot/#/builders/121/builds/24947` : [43/635] Building CXX object tools/clang/tools/extra/include-cleaner/lib/CMakeFiles/obj.clangIncludeCleaner.dir/Types.cpp.o FAILED: tools/clang/tools/extra/include-

[PATCH] D136723: [include-cleaner] Record main-file macro occurences and includes

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8249dc21046a: [include-cleaner] Record main-file macro occurences and includes (authored by sammccall). Changed prior to commit: https://reviews.l

[PATCH] D136723: [include-cleaner] Record main-file macro occurences and includes

sammccall updated this revision to Diff 471155. sammccall added a comment. const Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136723/new/ https://reviews.llvm.org/D136723 Files: clang-tools-extra/include-cleaner/include/clang-include-cleaner/Re

[PATCH] D136723: [include-cleaner] Record main-file macro occurences and includes

sammccall updated this revision to Diff 471150. sammccall marked 10 inline comments as done. sammccall added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136723/new/ https://reviews.llvm.org/D136723 Files: clang-tool

[PATCH] D136723: [include-cleaner] Record main-file macro occurences and includes

kadircet added inline comments. Comment at: clang-tools-extra/include-cleaner/include/clang-include-cleaner/Record.h:54 +struct RecordedPP { + // The callback (when installed into clang) tracks macros/includes in this. + std::unique_ptr record(const Preprocessor &PP);

[PATCH] D136723: [include-cleaner] Record main-file macro occurences and includes

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. looks good from my side. Comment at: clang-tools-extra/include-cleaner/include/clang-include-cleaner/Types.h:52 struct Symbol { enum Kind { // A canonical clang dec

[PATCH] D136723: [include-cleaner] Record main-file macro occurences and includes

sammccall updated this revision to Diff 470818. sammccall marked 5 inline comments as done. sammccall added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136723/new/ https://reviews.llvm.org/D136723 Files: clang-tools

[PATCH] D136723: [include-cleaner] Record main-file macro occurences and includes

hokein added a comment. Left a few initial comments, it looks roughly good to me (for the macro-usage case, I might miss some historical context there, I think we come to an agreement that what this patch proposes is the designed behavior). Comment at: clang-tools-extra/incl

[PATCH] D136723: [include-cleaner] Record main-file macro occurences and includes

sammccall added inline comments. Comment at: clang-tools-extra/include-cleaner/include/clang-include-cleaner/Record.h:75 +// - for a logical file like , we check Spelled +llvm::SmallVector match(Header H) const; + in the prototype I reimplemented this f

[PATCH] D136723: [include-cleaner] Record main-file macro occurences and includes

sammccall created this revision. sammccall added reviewers: kadircet, hokein. Herald added a project: All. sammccall requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. The occurrences are roots for finding used headers, like walkAS