sammccall added inline comments.
================ Comment at: clang-tools-extra/include-cleaner/include/clang-include-cleaner/Record.h:75 + // - for a logical file like <vector>, we check Spelled + llvm::SmallVector<const Include *> match(Header H) const; + ---------------- in the prototype I reimplemented this function in clangd, but I expect we can just reuse the RecordedIncludes class instead, copying from clangd's includes list is cheap. (That's one argument for putting this in a different header, which I can do already if you prefer) ================ Comment at: clang-tools-extra/include-cleaner/include/clang-include-cleaner/Types.h:22 -#ifndef CLANG_INCLUDE_CLEANER_RECORD_H -#define CLANG_INCLUDE_CLEANER_RECORD_H +#ifndef CLANG_INCLUDE_CLEANER_TYPES_H +#define CLANG_INCLUDE_CLEANER_TYPES_H ---------------- (this is already fixed at head) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136723/new/ https://reviews.llvm.org/D136723 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
