[PATCH] D136602: NFC: [clang] Template argument cleanups.

mizvekov added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/UseTransparentFunctorsCheck.cpp:101 +const TemplateArgument &Arg = +FunctorParentType->template_arguments()[ArgNum]; if (Arg.getKind() != TemplateArgument::Type)

[PATCH] D136602: NFC: [clang] Template argument cleanups.

thakis added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/UseTransparentFunctorsCheck.cpp:101 +const TemplateArgument &Arg = +FunctorParentType->template_arguments()[ArgNum]; if (Arg.getKind() != TemplateArgument::Type) Th

[PATCH] D136602: NFC: [clang] Template argument cleanups.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1acffe81ee91: NFC: [clang] Template argument cleanups. (authored by mizvekov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[PATCH] D136602: NFC: [clang] Template argument cleanups.

mizvekov updated this revision to Diff 470289. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136602/new/ https://reviews.llvm.org/D136602 Files: clang-tools-extra/clang-tidy/modernize/UseTransparentFunctorsCheck.cpp clang-tools-extra/clang-tidy/

[PATCH] D136602: NFC: [clang] Template argument cleanups.

mizvekov updated this revision to Diff 470278. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136602/new/ https://reviews.llvm.org/D136602 Files: clang-tools-extra/clang-tidy/modernize/UseTransparentFunctorsCheck.cpp clang-tools-extra/clang-tidy/

[PATCH] D136602: NFC: [clang] Template argument cleanups.

mizvekov updated this revision to Diff 470266. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136602/new/ https://reviews.llvm.org/D136602 Files: clang-tools-extra/clang-tidy/modernize/UseTransparentFunctorsCheck.cpp clang-tools-extra/clang-tidy/

[PATCH] D136602: NFC: [clang] Template argument cleanups.

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. LGTM once that one overload is removed (the non const one). I'd rather we justify at that point WHY we need that overload in a separate review. Comment at: clang/in

[PATCH] D136602: NFC: [clang] Template argument cleanups.

mizvekov added inline comments. Comment at: clang/include/clang/AST/TemplateBase.h:592 + llvm::ArrayRef arguments() const { return Arguments; } + llvm::MutableArrayRef arguments() { return Arguments; } erichkeane wrote: > Ooh, really? Are the use cases ones

[PATCH] D136602: NFC: [clang] Template argument cleanups.

erichkeane added a comment. I like this cleanup in general, just 2 questions. Comment at: clang/include/clang/AST/TemplateBase.h:592 + llvm::ArrayRef arguments() const { return Arguments; } + llvm::MutableArrayRef arguments() { return Arguments; } Ooh, real

[PATCH] D136602: NFC: [clang] Template argument cleanups.

mizvekov created this revision. Herald added subscribers: carlosgalvezp, kadircet, arphaman, martong. Herald added a reviewer: shafik. Herald added a project: All. mizvekov requested review of this revision. Herald added projects: clang, clang-tools-extra. Herald added a subscriber: cfe-commits. R