erichkeane added a comment.
I like this cleanup in general, just 2 questions.
================
Comment at: clang/include/clang/AST/TemplateBase.h:592
+ llvm::ArrayRef<TemplateArgumentLoc> arguments() const { return Arguments; }
+ llvm::MutableArrayRef<TemplateArgumentLoc> arguments() { return Arguments; }
----------------
Ooh, really? Are the use cases ones where others are modifying this arguments
list in place? All the functions you removed seem to be 'const'.
================
Comment at: clang/include/clang/AST/Type.h:5298
- void Profile(llvm::FoldingSetNodeID &ID, const ASTContext &Context) {
- Profile(ID, Context, getDeducedType(), getKeyword(), isDependentType(),
----------------
What is happening here?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D136602/new/
https://reviews.llvm.org/D136602
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
