This revision was automatically updated to reflect the committed changes.
Closed by commit rL250060: [VFS] Let the user decide if they want path
normalization. (authored by d0k).
Changed prior to commit:
http://reviews.llvm.org/D13658?vs=37124&id=37125#toc
Repository:
rL LLVM
http://reviews
klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
lg
Comment at: include/clang/Basic/VirtualFileSystem.h:282
@@ -280,2 +281,3 @@
/// Add a buffer to the VFS with a path. The VFS owns the buffer.
- void addFile(const Twine
bkramer updated this revision to Diff 37124.
bkramer added a comment.
Addressed review comments.
http://reviews.llvm.org/D13658
Files:
include/clang/Basic/VirtualFileSystem.h
lib/Basic/VirtualFileSystem.cpp
unittests/Basic/VirtualFileSystemTest.cpp
Index: unittests/Basic/VirtualFileSyste
klimek added inline comments.
Comment at: include/clang/Basic/VirtualFileSystem.h:276
@@ -275,2 +275,3 @@
std::string WorkingDirectory;
+ bool UseNormalizedPaths;
I'd use an in class initializer.
Comment at: include/clang/Basic/VirtualFileS
bkramer created this revision.
bkramer added a reviewer: klimek.
bkramer added a subscriber: cfe-commits.
This is a more principled version of what I did earlier. Path
normalization is generally a good thing, but may break users in strange
environments, e. g. using lots of symlinks. Let the user c
