klimek added inline comments. ================ Comment at: include/clang/Basic/VirtualFileSystem.h:276 @@ -275,2 +275,3 @@ std::string WorkingDirectory; + bool UseNormalizedPaths; ---------------- I'd use an in class initializer.
================ Comment at: include/clang/Basic/VirtualFileSystem.h:282 @@ -280,2 +281,3 @@ /// Add a buffer to the VFS with a path. The VFS owns the buffer. - void addFile(const Twine &Path, time_t ModificationTime, + /// \return true if the file was successfully added. + bool addFile(const Twine &Path, time_t ModificationTime, ---------------- Document in which cases false can happen (or return a status). http://reviews.llvm.org/D13658 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
