[PATCH] D136436: [Clang][LoongArch] Add register alias handling without `$` prefix

SixWeining updated this revision to Diff 521541. SixWeining added a comment. Only allow non-prefixed names for GPRs. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136436/new/ https://reviews.llvm.org/D136436 Files: clang/lib/Basic/Targets/LoongA

[PATCH] D136436: [Clang][LoongArch] Add register alias handling without `$` prefix

tangyouling added a comment. The patch will continue to be updated by @SixWeining . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136436/new/ https://reviews.llvm.org/D136436 ___ cfe-commits mailing list

[PATCH] D136436: [Clang][LoongArch] Add register alias handling without `$` prefix

SixWeining added a comment. In D136436#4314612 , @xen0n wrote: > Hi, any update on this? Given the `$`-less style has been long established at > this time, and present in released GCC versions, it seems we indeed have to > follow suit (and later make GC

[PATCH] D136436: [Clang][LoongArch] Add register alias handling without `$` prefix

xen0n added a comment. Hi, any update on this? Given the `$`-less style has been long established at this time, and present in released GCC versions, it seems we indeed have to follow suit (and later make GCC accept ABI names for FPRs too). It will also make the ClangBuiltLinux work easier. R

[PATCH] D136436: [Clang][LoongArch] Add register alias handling without `$` prefix

tangyouling added a comment. In D136436#3898394 , @SixWeining wrote: > In D136436#3898392 , @tangyouling > wrote: > >> Is it acceptable to add the `non-prefix $`? if not, an alternative fix for >> the build fai

[PATCH] D136436: [Clang][LoongArch] Add register alias handling without `$` prefix

xry111 added a comment. In D136436#3898398 , @xry111 wrote: > In D136436#3898392 , @tangyouling > wrote: > >> Is it acceptable to add the `non-prefix $`? if not, an alternative fix for >> the build failure is to

[PATCH] D136436: [Clang][LoongArch] Add register alias handling without `$` prefix

xry111 added a comment. In D136436#3898392 , @tangyouling wrote: > Is it acceptable to add the `non-prefix $`? if not, an alternative fix for > the build failure is to add the `prefix $` in > sanitizer_syscall_linux_loongarch64.inc I wrote `sanitizer_

[PATCH] D136436: [Clang][LoongArch] Add register alias handling without `$` prefix

SixWeining added a comment. In D136436#3898392 , @tangyouling wrote: > Is it acceptable to add the `non-prefix $`? if not, an alternative fix for > the build failure is to add the `prefix $` in > sanitizer_syscall_linux_loongarch64.inc People have dif

[PATCH] D136436: [Clang][LoongArch] Add register alias handling without `$` prefix

tangyouling added a comment. Is it acceptable to add the `non-prefix $`? if not, an alternative fix for the build failure is to add the `prefix $` in sanitizer_syscall_linux_loongarch64.inc Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136436/new/

[PATCH] D136436: [Clang][LoongArch] Add register alias handling without `$` prefix

tangyouling added a comment. In D136436#3890737 , @SixWeining wrote: > In D136436#3881382 , @MaskRay wrote: > >> In D136436#3876684 , @SixWeining >> wrote: >> >>> In D13

[PATCH] D136436: [Clang][LoongArch] Add register alias handling without `$` prefix

xen0n added a comment. In D136436#3890737 , @SixWeining wrote: > In D136436#3881382 , @MaskRay wrote: > >> In D136436#3876684 , @SixWeining >> wrote: >> >>> In D136436#3

[PATCH] D136436: [Clang][LoongArch] Add register alias handling without `$` prefix

SixWeining added a comment. In D136436#3881382 , @MaskRay wrote: > In D136436#3876684 , @SixWeining > wrote: > >> In D136436#3873987 , @xen0n wrote: >> >>> In D136436#387

[PATCH] D136436: [Clang][LoongArch] Add register alias handling without `$` prefix

MaskRay added a comment. In D136436#3876684 , @SixWeining wrote: > In D136436#3873987 , @xen0n wrote: > >> In D136436#3873949 , @SixWeining >> wrote: >> >>> How about th

[PATCH] D136436: [Clang][LoongArch] Add register alias handling without `$` prefix

tangyouling added a comment. In D136436#3873938 , @xen0n wrote: > Commit message is unclear. You added non-prefixed aliases for all registers, > yet only `$a0` is mentioned. I'd like to see what improvement you could come > up with before amending it my

[PATCH] D136436: [Clang][LoongArch] Add register alias handling without `$` prefix

tangyouling updated this revision to Diff 470028. tangyouling added a comment. Modify commit information and add missing `s9`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136436/new/ https://reviews.llvm.org/D136436 Files: clang/lib/Basic/Targ

[PATCH] D136436: [Clang][LoongArch] Add register alias handling without `$` prefix

SixWeining added a comment. In D136436#3873987 , @xen0n wrote: > In D136436#3873949 , @SixWeining > wrote: > >> How about the asm code in `.s`? Do we need to support `addi.d a0, a1, a2`? > > For the assembler par

[PATCH] D136436: [Clang][LoongArch] Add register alias handling without `$` prefix

xen0n added a comment. In D136436#3873949 , @SixWeining wrote: > How about the asm code in `.s`? Do we need to support `addi.d a0, a1, a2`? For the assembler part of this support, I think we need to coordinate with the GNU toolchain maintainers of Loon

[PATCH] D136436: [Clang][LoongArch] Add register alias handling without `$` prefix

SixWeining added a comment. How about the asm code in `.s`? Do we need to support `addi.d a0, a1, a2`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136436/new/ https://reviews.llvm.org/D136436 ___ cfe-c

[PATCH] D136436: [Clang][LoongArch] Add register alias handling without `$` prefix

tangyouling added a comment. $ cat prefix_regalias.c int main() { register unsigned long a0 asm("a0"); register unsigned long a1 asm("$a1"); register unsigned long a2 asm("r6"); register unsigned long a3 asm("$r7"); register float f0 asm("fa0");

[PATCH] D136436: [Clang][LoongArch] Add register alias handling without `$` prefix

xen0n added a comment. Commit message is unclear. You added non-prefixed aliases for all registers, yet only `$a0` is mentioned. I'd like to see what improvement you could come up with before amending it myself, to hopefully make you better at writing those "small compositions".

[PATCH] D136436: [Clang][LoongArch] Add register alias handling without `$` prefix

tangyouling created this revision. tangyouling added reviewers: SixWeining, xen0n, xry111, MaskRay, wangleiat. Herald added subscribers: jeroen.dobbelaere, StephenFan. Herald added a project: All. tangyouling requested review of this revision. Herald added a project: clang. Herald added a subscribe