tangyouling added a comment.
In D136436#3873938 <https://reviews.llvm.org/D136436#3873938>, @xen0n wrote:
> Commit message is unclear. You added non-prefixed aliases for all registers,
> yet only `$a0` is mentioned. I'd like to see what improvement you could come
> up with before amending it myself, to hopefully make you better at writing
> those "small compositions".
Updated the description of all registers, thanks for pointing it out.
================
Comment at: clang/lib/Basic/Targets/LoongArch.cpp:52
+ {{"t8", "$t8", "r20"}, "$r20"}, {{"r21"}, "$r21"},
+ {{"fp", "$fp", "r22", "$s9"}, "$r22"}, {{"s0", "$s0", "r23"}, "$r23"},
+ {{"s1", "$s1", "r24"}, "$r24"}, {{"s2", "$s2", "r25"}, "$r25"},
----------------
xen0n wrote:
> Missing `"s9"`.
OK, modified.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D136436/new/
https://reviews.llvm.org/D136436
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
