[PATCH] D136084: Fix LIT CodeGen/Func-attr.c

2022-10-17 Thread Zahira Ammarguellat via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGd0a4741392a3: Fix LIT test func-attr.c added by https://reviews.llvm.org/D135097. (authored by zahiraam). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D13608

[PATCH] D136084: Fix LIT CodeGen/Func-attr.c

2022-10-17 Thread John McCall via Phabricator via cfe-commits
rjmccall added a comment. With these changes in place, this looks fine to me. The underlying problem here is that portable IR generation has gotten too difficult to test textually. FileCheck mostly works fine for testing IR passes, where we rarely worry about target dependencies and carefully

[PATCH] D136084: Fix LIT CodeGen/Func-attr.c

2022-10-17 Thread Zahira Ammarguellat via Phabricator via cfe-commits
zahiraam updated this revision to Diff 468236. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136084/new/ https://reviews.llvm.org/D136084 Files: clang/test/CodeGen/func-attr.c Index: clang/test/CodeGen/func-attr.c === --

[PATCH] D136084: Fix LIT CodeGen/Func-attr.c

2022-10-17 Thread Erich Keane via Phabricator via cfe-commits
erichkeane added inline comments. Comment at: clang/test/CodeGen/func-attr.c:1 -// RUN: %clang -c -ffast-math -emit-llvm -S -o - %s \ -// RUN: | FileCheck %s +// RUN: %clang -c -O2 -target x86_64 -ffast-math\ +// RUN: -emit-llvm -S -o - %s | FileCheck %s zahiraa

[PATCH] D136084: Fix LIT CodeGen/Func-attr.c

2022-10-17 Thread Zahira Ammarguellat via Phabricator via cfe-commits
zahiraam added inline comments. Comment at: clang/test/CodeGen/func-attr.c:1 -// RUN: %clang -c -ffast-math -emit-llvm -S -o - %s \ -// RUN: | FileCheck %s +// RUN: %clang -c -O2 -target x86_64 -ffast-math\ +// RUN: -emit-llvm -S -o - %s | FileCheck %s erichkean

[PATCH] D136084: Fix LIT CodeGen/Func-attr.c

2022-10-17 Thread Erich Keane via Phabricator via cfe-commits
erichkeane added inline comments. Comment at: clang/test/CodeGen/func-attr.c:1 -// RUN: %clang -c -ffast-math -emit-llvm -S -o - %s \ -// RUN: | FileCheck %s +// RUN: %clang -c -O2 -target x86_64 -ffast-math\ +// RUN: -emit-llvm -S -o - %s | FileCheck %s It isn'

[PATCH] D136084: Fix LIT CodeGen/Func-attr.c

2022-10-17 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added reviewers: efriedma, rjmccall. aaron.ballman added a comment. I've added some more codegen reviewers; I think we usually try to avoid CodeGen tests that rely on specific optimization levels. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D136084: Fix LIT CodeGen/Func-attr.c

2022-10-17 Thread Zahira Ammarguellat via Phabricator via cfe-commits
zahiraam added a comment. @saugustine A, @jrtc27. Thanks for your comments. Adding '-target x86_64' is restrictive, but not sure what option to use to express that I want target with zero as default address. @aaron.ballman what do you think? Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D136084: Fix LIT CodeGen/Func-attr.c

2022-10-17 Thread Zahira Ammarguellat via Phabricator via cfe-commits
zahiraam created this revision. zahiraam added reviewers: jrtc27, saugustine, aaron.ballman. Herald added a project: All. zahiraam requested review of this revision. Herald added a project: clang. See details in comment https://reviews.llvm.org/D135097#3859893 and https://reviews.llvm.org/D135097