rjmccall added a comment. With these changes in place, this looks fine to me.
The underlying problem here is that portable IR generation has gotten too difficult to test textually. FileCheck mostly works fine for testing IR passes, where we rarely worry about target dependencies and carefully control the input, but there are too many variables in IR generation these days that result in too much variation in the output. The result is that our test suite overwhelmingly tests specific targets instead of striving for portability. Ah well. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136084/new/ https://reviews.llvm.org/D136084 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
