[PATCH] D136031: [DirectX backend] support ConstantBuffer to DXILResource.h

python3kgae added a comment. In D136031#4062756 , @beanz wrote: > @python3kgae, this change introduced a bunch of warning spew because it is > using an API that was deprecated shortly before the change merged. Can you > please address this? Sure. I'll

[PATCH] D136031: [DirectX backend] support ConstantBuffer to DXILResource.h

beanz added a comment. @python3kgae, this change introduced a bunch of warning spew because it is using an API that was deprecated shortly before the change merged. Can you please address this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136031/

[PATCH] D136031: [DirectX backend] support ConstantBuffer to DXILResource.h

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG944f4b280585: [DirectX backend] add support ConstantBuffer to DXILResource.h (authored by python3kgae). Repository: rG LLVM Github Monorepo CHANG

[PATCH] D136031: [DirectX backend] support ConstantBuffer to DXILResource.h

python3kgae updated this revision to Diff 488707. python3kgae added a comment. Fix test fail after rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136031/new/ https://reviews.llvm.org/D136031 Files: llvm/lib/Target/DirectX/CBufferDataLayou

[PATCH] D136031: [DirectX backend] support ConstantBuffer to DXILResource.h

beanz accepted this revision. beanz added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136031/new/ https://reviews.llvm.org/D136031 ___ c

[PATCH] D136031: [DirectX backend] support ConstantBuffer to DXILResource.h

python3kgae updated this revision to Diff 486390. python3kgae added a comment. Add unit test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136031/new/ https://reviews.llvm.org/D136031 Files: llvm/lib/Target/DirectX/CBufferDataLayout.cpp llvm/

[PATCH] D136031: [DirectX backend] support ConstantBuffer to DXILResource.h

python3kgae updated this revision to Diff 486070. python3kgae added a comment. Use llvm::TypeSize and uint32_t instead of unsigned. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136031/new/ https://reviews.llvm.org/D136031 Files: llvm/lib/Target

[PATCH] D136031: [DirectX backend] support ConstantBuffer to DXILResource.h

beanz added a comment. It is probably worth adding some unit tests to test the `CBufferDataLayout` class. I think the meat of this change is fine. This code mixes `unsigned` and `uint32_t` interchangeably. They aren't required by the language to be the same. I have a general preference toward

[PATCH] D136031: [DirectX backend] support ConstantBuffer to DXILResource.h

python3kgae updated this revision to Diff 485747. python3kgae added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136031/new/ https://reviews.llvm.org/D136031 Files: llvm/lib/Target/DirectX/CBufferDataLayout.cpp llvm/lib/Targ

[PATCH] D136031: [DirectX backend] support ConstantBuffer to DXILResource.h

python3kgae updated this revision to Diff 482620. python3kgae added a comment. Rebase and remove the counter in resource metadata to match clang change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136031/new/ https://reviews.llvm.org/D136031 Fil

[PATCH] D136031: [DirectX backend] support ConstantBuffer to DXILResource.h

python3kgae updated this revision to Diff 468054. python3kgae added a comment. Rebase to fix stack patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136031/new/ https://reviews.llvm.org/D136031 Files: llvm/lib/Target/DirectX/CBufferDataLayout.

[PATCH] D136031: [DirectX backend] support ConstantBuffer to DXILResource.h

python3kgae updated this revision to Diff 468047. python3kgae added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. arc diff `git merge-base HEAD origin` --update D136031 to fix the apply patch issue Repository: rG LLVM Gith