[PATCH] D135372: [clang-format] Fix for #58188

2022-10-11 Thread sstwcw via Phabricator via cfe-commits
sstwcw abandoned this revision. sstwcw added a comment. I am closing it now there is D135740 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135372/new/ https://reviews.llvm.org/D135372 ___

[PATCH] D135372: [clang-format] Fix for #58188

2022-10-06 Thread sstwcw via Phabricator via cfe-commits
sstwcw added a comment. The problem that remains is this, as I explained in the issue. The second branch of the second block is not indented. #if 1 { #endif #if X x; #else x; #endif } I didn't add a test case because I was not expecting this patch to be committed as there

[PATCH] D135372: [clang-format] Fix for #58188

2022-10-06 Thread sstwcw via Phabricator via cfe-commits
sstwcw updated this revision to Diff 465772. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135372/new/ https://reviews.llvm.org/D135372 Files: clang/lib/Format/UnwrappedLineParser.cpp Index: clang/lib/Format/UnwrappedLineParser.cpp =

[PATCH] D135372: [clang-format] Fix for #58188

2022-10-06 Thread Björn Schäpers via Phabricator via cfe-commits
HazardyKnusperkeks added a comment. What is the problem that remains? Please add a test case. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:1142-1143 + PPStack.back().Kind == PP_Unreachable && + !(PPStack.size() > 1 && +PPStack[PPStack.size() - 2].Kind

[PATCH] D135372: [clang-format] Fix for #58188

2022-10-06 Thread sstwcw via Phabricator via cfe-commits
sstwcw added a comment. See https://github.com/llvm/llvm-project/issues/58188#issuecomment-1270355888. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135372/new/ https://reviews.llvm.org/D135372 ___ cfe-c

[PATCH] D135372: [clang-format] Fix for #58188

2022-10-06 Thread sstwcw via Phabricator via cfe-commits
sstwcw created this revision. sstwcw added reviewers: HazardyKnusperkeks, MyDeveloperDay, curdeius, owenpan, sammccall. sstwcw added a project: clang-format. Herald added a project: All. sstwcw requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits