[PATCH] D135287: Disallow dereferencing of void* in C++.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6685e56ceddf: Disallow dereferencing of void* in C++. (authored by erichkeane). Herald added a project: clang. Changed prior to commit: https://re

[PATCH] D135287: Disallow dereferencing of void* in C++.

erichkeane updated this revision to Diff 465725. erichkeane marked 2 inline comments as done. erichkeane added a comment. Fix based on Aaron's comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135287/new/ https://reviews.llvm.org/D135287 Files: clang/docs/ReleaseNotes.rst cla

[PATCH] D135287: Disallow dereferencing of void* in C++.

erichkeane marked 4 inline comments as done. erichkeane added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:6939-6942 + // Note: This uses a different diagnostics group than the C diagnostic + // so that projects that have disabled the ab

[PATCH] D135287: Disallow dereferencing of void* in C++.

aaron.ballman added a comment. In D135287#3837617 , @erichkeane wrote: > In D135287#3837584 , @jrtc27 wrote: > >> What about `__typeof__(*p)`? > > Yes, that would also be an error in C++, as it is on all other co

[PATCH] D135287: Disallow dereferencing of void* in C++.

erichkeane updated this revision to Diff 465707. erichkeane marked an inline comment as done. erichkeane added a comment. fix the release note spelling of permanent. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135287/new/ https://reviews.llvm.org/D135287 Files: clang/docs/ReleaseNo

[PATCH] D135287: Disallow dereferencing of void* in C++.

shafik accepted this revision as: shafik. shafik added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/docs/ReleaseNotes.rst:92 + error so constraint checking and SFINAE checking can be compatible with other + compilers. It is likely that th

[PATCH] D135287: Disallow dereferencing of void* in C++.

erichkeane added a comment. In D135287#3837584 , @jrtc27 wrote: > What about `__typeof__(*p)`? Yes, that would also be an error in C++, as it is on all other compilers. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135287/new/ https://reviews.

[PATCH] D135287: Disallow dereferencing of void* in C++.

jrtc27 added a comment. What about `__typeof__(*p)`? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135287/new/ https://reviews.llvm.org/D135287 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/lis

[PATCH] D135287: Disallow dereferencing of void* in C++.

erichkeane added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:6938 +def ext_typecheck_indirection_through_void_pointer_cpp +: ExtWarn<"ISO C++ does not allow indirection on operand of type %0">, + // Note: This uses a different diagnostic

[PATCH] D135287: Disallow dereferencing of void* in C++.

cor3ntin added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:6938 +def ext_typecheck_indirection_through_void_pointer_cpp +: ExtWarn<"ISO C++ does not allow indirection on operand of type %0">, + // Note: This uses a different diagnostics

[PATCH] D135287: Disallow dereferencing of void* in C++.

aaron.ballman added a reviewer: clang-vendors. aaron.ballman added a comment. Adding the vendors group due to the potential to break existing code. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135287/new/ https://reviews.llvm.org/D135287 ___

[PATCH] D135287: Disallow dereferencing of void* in C++.

erichkeane added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:6938 +def ext_typecheck_indirection_through_void_pointer_cpp +: ExtWarn<"ISO C++ does not allow indirection on operand of type %0">, + // Note: This uses a different diagnostic

[PATCH] D135287: Disallow dereferencing of void* in C++.

erichkeane created this revision. erichkeane added a reviewer: clang-language-wg. Herald added a project: All. erichkeane requested review of this revision. as Discussed: https://discourse.llvm.org/t/rfc-can-we-stop-the-extension-to-allow-dereferencing-void-in-c/65708 There is no good reason to a