Re: [PATCH] D135245: [clang][Tooling] Move STL recognizer to its own library

sorry for that, bb4f0af97dba600c50a0f727b25a760e8185c578 should fix it On Fri, Oct 7, 2022 at 7:46 PM Kamau Bridgeman via Phabricator < revi...@reviews.llvm.org> wrote: > kamaub added a comment. > > This change causes a linking failure during the `check-all` testing of > 'clang-tools-extra' on th

[PATCH] D135245: [clang][Tooling] Move STL recognizer to its own library

kamaub added a comment. This change causes a linking failure during the `check-all` testing of 'clang-tools-extra' on the clang-ppc64le-rhel #22596 and clang-ppc64le-linux-multistage #23864

[PATCH] D135245: [clang][Tooling] Move STL recognizer to its own library

thakis added a comment. (Alternatively, it looks like the only client is clangd, so maybe the file could just live in there instead of being in a dedicated library with a single client.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135245/new/ h

[PATCH] D135245: [clang][Tooling] Move STL recognizer to its own library

thakis added a comment. Thanks! Comment at: clang/lib/Tooling/Inclusions/STL/CMakeLists.txt:2 +add_clang_library(clangToolingInclusionsSTL + StandardLibrary.cpp + kadircet wrote: > sammccall wrote: > > This means the implementation files and the header files h

[PATCH] D135245: [clang][Tooling] Move STL recognizer to its own library

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd1f13c54f172: [clang][Tooling] Move STL recognizer to its own library (authored by kadircet). Changed prior to commit: https://reviews.llvm.org/D1

[PATCH] D135245: [clang][Tooling] Move STL recognizer to its own library

kadircet updated this revision to Diff 465671. kadircet marked 2 inline comments as done. kadircet added a comment. - Rename STL to Stdlib Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135245/new/ https://reviews.llvm.org/D135245 Files: clang-to

[PATCH] D135245: [clang][Tooling] Move STL recognizer to its own library

kadircet marked 2 inline comments as done. kadircet added inline comments. Comment at: clang-tools-extra/clangd/CMakeLists.txt:163 clangToolingInclusions + clangToolingInclusionsSTL clangToolingSyntax sammccall wrote: > StandardLibrary or Stdlib? > > STL

[PATCH] D135245: [clang][Tooling] Move STL recognizer to its own library

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/CMakeLists.txt:163 clangToolingInclusions + clangToolingInclusionsSTL clangToolingSyntax StandardLibrar

[PATCH] D135245: [clang][Tooling] Move STL recognizer to its own library

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added a subscriber: arphaman. Herald added a project: All. kadircet requested review of this revision. Herald added projects: clang, clang-tools-extra. Herald added a subscriber: cfe-commits. As pointed out in https://rev