[PATCH] D135076: [Clang] Make offloading flags accept '-' and '--'

tra added a comment. In D135076#3831563 , @MaskRay wrote: > Another idea is to reject multiple `-o` if some are used as the `Joined` > form. Note: multiple `Separate` `-o` should be allowed. > It will not catch `-offload-*` when `-o output` is not specif

[PATCH] D135076: [Clang] Make offloading flags accept '-' and '--'

MaskRay added a comment. Sorry, but I'll revert this patch shortly. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135076/new/ https://reviews.llvm.org/D135076 ___ cfe-commits mailing list cfe-commits@lis

[PATCH] D135076: [Clang] Make offloading flags accept '-' and '--'

MaskRay added a comment. Another idea is to reject multiple `-o` if some are used as the `Joined` form. Note: multiple `Separate` `-o` should be allowed. It will not catch `-offload-*` when `-o output` is not specified, but is probably useful enough. Repository: rG LLVM Github Monorepo CHAN

[PATCH] D135076: [Clang] Make offloading flags accept '-' and '--'

MaskRay added a comment. In D135076#3831371 , @jhuber6 wrote: > In D135076#3831363 , @MaskRay wrote: > >> My idea is to just disallow `Joined` `-o` when targeting a specific >> environment (e.g. when offloading t

[PATCH] D135076: [Clang] Make offloading flags accept '-' and '--'

jhuber6 added a comment. In D135076#3831363 , @MaskRay wrote: > My idea is to just disallow `Joined` `-o` when targeting a specific > environment (e.g. when offloading toolchain is used). This seems difficult as we only know which offloading toolchains

[PATCH] D135076: [Clang] Make offloading flags accept '-' and '--'

MaskRay added a comment. In D135076#3831347 , @jhuber6 wrote: > In D135076#3831340 , @MaskRay wrote: > >> In D135076#3831307 , @jhuber6 >> wrote: >> >>> In D135076#383129

[PATCH] D135076: [Clang] Make offloading flags accept '-' and '--'

jhuber6 added a comment. In D135076#3831340 , @MaskRay wrote: > In D135076#3831307 , @jhuber6 wrote: > >> In D135076#3831298 , @MaskRay >> wrote: >> >>> We really want th

[PATCH] D135076: [Clang] Make offloading flags accept '-' and '--'

MaskRay added a comment. In D135076#3831307 , @jhuber6 wrote: > In D135076#3831298 , @MaskRay wrote: > >> We really want these `--offload-*` users to stick with one canonical form, >> not `-offload-*` in some pla

[PATCH] D135076: [Clang] Make offloading flags accept '-' and '--'

jhuber6 added a comment. In D135076#3831298 , @MaskRay wrote: > We really want these `--offload-*` users to stick with one canonical form, > not `-offload-*` in some places while `--offload-*` in other places. > > Another angle is that people find `-offl

[PATCH] D135076: [Clang] Make offloading flags accept '-' and '--'

MaskRay added a comment. We really want these `--offload-*` users to stick with one canonical form, not `-offload-*` in some places while `--offload-*` in other places. Another angle is that people find `-offload-*` working with a new clang may try `-offload-*` on an old clang and get `-o ffloa

[PATCH] D135076: [Clang] Make offloading flags accept '-' and '--'

MaskRay added a comment. In D135076#3830989 , @jhuber6 wrote: > In D135076#3830972 , @MaskRay wrote: > >> There are traditionally some single-dash long options (perhaps classical Mac >> OS style) which conflict w

[PATCH] D135076: [Clang] Make offloading flags accept '-' and '--'

jhuber6 added a comment. In D135076#3830972 , @MaskRay wrote: > There are traditionally some single-dash long options (perhaps classical Mac > OS style) which conflict with short options. I think nowadays we try to avoid > such single-dash short options

[PATCH] D135076: [Clang] Make offloading flags accept '-' and '--'

MaskRay added a comment. There are traditionally some single-dash long options (perhaps classical Mac OS style) which conflict with short options. I think nowadays we try to avoid such single-dash short options. (For example, GNU ld now requires all new long options to use two-dashes, after kno

[PATCH] D135076: [Clang] Make offloading flags accept '-' and '--'

jdoerfert added a comment. In D135076#3830914 , @MaskRay wrote: > Single-dash long options starting with `-o` conflict with the short option > `-o` so I am unsure I like this direction. > >> However, if a user uses a single dash it will instead name a fi

[PATCH] D135076: [Clang] Make offloading flags accept '-' and '--'

jhuber6 added a comment. In D135076#3830914 , @MaskRay wrote: > Single-dash long options starting with `-o` conflict with the short option > `-o` so I am unsure I like this direction. > >> However, if a user uses a single dash it will instead name a file

[PATCH] D135076: [Clang] Make offloading flags accept '-' and '--'

MaskRay added a comment. I think this should be reverted. It's moving in the backward direction. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135076/new/ https://reviews.llvm.org/D135076 ___ cfe-commits

[PATCH] D135076: [Clang] Make offloading flags accept '-' and '--'

MaskRay added a comment. Single-dash long options starting with `-o` conflict with the short option `-o` so I am unsure I like this direction. > This is similar to many other driver arguments beginning with -o. What options? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[PATCH] D135076: [Clang] Make offloading flags accept '-' and '--'

This revision was automatically updated to reflect the committed changes. Closed by commit rG11adae50892e: [Clang] Make offloading flags accept '-' and '--' (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135076/new/ https://rev

[PATCH] D135076: [Clang] Make offloading flags accept '-' and '--'

JonChesterfield accepted this revision. JonChesterfield added a comment. This revision is now accepted and ready to land. Like that a lot, good quality of life improvement. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135076/new/ https://reviews.l

[PATCH] D135076: [Clang] Make offloading flags accept '-' and '--'

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, JonChesterfield, tra, yaxunl, tianshilei1992, MaskRay. Herald added a subscriber: StephenFan. Herald added a project: All. jhuber6 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-com