This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG77aaf469a7ae: [clang][Interp] Implement ConditionalOperators
(authored by tbaeder).
Changed prior to commit:
https://reviews.llvm.org/D134801?vs=4
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM!
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D134801/new/
https://reviews.llvm.org/D134801
___
cfe-commits mailing lis
tbaeder added inline comments.
Comment at: clang/lib/AST/Interp/ByteCodeExprGen.h:90
bool VisitOpaqueValueExpr(const OpaqueValueExpr *E);
+ bool VisitConditionalOperator(const ConditionalOperator *E);
aaron.ballman wrote:
> Do we want to handle `BinaryCondi
tbaeder updated this revision to Diff 464165.
tbaeder marked 3 inline comments as done.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D134801/new/
https://reviews.llvm.org/D134801
Files:
clang/lib/AST/Interp/ByteCodeExprGen.cpp
clang/lib/AST/Interp/ByteCodeExprGen.h
clang/test/AST/I
aaron.ballman added inline comments.
Comment at: clang/lib/AST/Interp/ByteCodeExprGen.h:90
bool VisitOpaqueValueExpr(const OpaqueValueExpr *E);
+ bool VisitConditionalOperator(const ConditionalOperator *E);
Do we want to handle `BinaryConditionalOperator` a
shafik added inline comments.
Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:357
+
+ if (!this->visit(Condition))
+return false;
tbaeder wrote:
> shafik wrote:
> > Maybe I am misunderstanding what this is doing but can't we just check the
> > result o
tbaeder added inline comments.
Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:357
+
+ if (!this->visit(Condition))
+return false;
shafik wrote:
> Maybe I am misunderstanding what this is doing but can't we just check the
> result of the condition and
shafik added inline comments.
Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:357
+
+ if (!this->visit(Condition))
+return false;
Maybe I am misunderstanding what this is doing but can't we just check the
result of the condition and then just visit eit
tbaeder created this revision.
tbaeder added reviewers: aaron.ballman, erichkeane, tahonermann, shafik.
Herald added a project: All.
tbaeder requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Implement visiting `ConditionalOperator`s.
This al
