shafik added inline comments.

================
Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:357
+
+  if (!this->visit(Condition))
+    return false;
----------------
Maybe I am misunderstanding what this is doing but can't we just check the 
result of the condition and then just visit either the true or false branch?  


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134801/new/

https://reviews.llvm.org/D134801

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to