[PATCH] D134542: [Concepts] Recover properly from a RecoveryExpr in a concept

This revision was automatically updated to reflect the committed changes. Closed by commit rG684a78968bd3: Reapply "[Concepts] Recover properly from a RecoveryExpr in a concept" (authored by erichkeane). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/D134542?vs

[PATCH] D134542: [Concepts] Recover properly from a RecoveryExpr in a concept

ychen added a comment. In D134542#3814029 , @erichkeane wrote: > Thanks for the quick review! Yeah, that case is a tough one, we don't really > have a good way of determining whether that was supposed to fail, or be the > best match. GCC does the opt

[PATCH] D134542: [Concepts] Recover properly from a RecoveryExpr in a concept

erichkeane added a comment. In D134542#3812711 , @ychen wrote: > In D134542#3812292 , @erichkeane > wrote: > >> In D134542#3812211 , @ychen wrote: >> >>> The patch looks

[PATCH] D134542: [Concepts] Recover properly from a RecoveryExpr in a concept

ychen accepted this revision as: ychen. ychen added a comment. This revision is now accepted and ready to land. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134542/new/ https://reviews.llvm.org/D134542 ___ cfe-commits mailing list cfe-

[PATCH] D134542: [Concepts] Recover properly from a RecoveryExpr in a concept

ychen added a comment. In D134542#3812292 , @erichkeane wrote: > In D134542#3812211 , @ychen wrote: > >> The patch looks good. Two high-level questions: >> >> - Does the similar thing happen for class templates?

[PATCH] D134542: [Concepts] Recover properly from a RecoveryExpr in a concept

erichkeane updated this revision to Diff 462568. erichkeane added a comment. Changes as suggested by @ychen. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134542/new/ https://reviews.llvm.org/D134542 Files: clang/docs/ReleaseNotes.rst clang/include/clang/AST/ASTConcept.h

[PATCH] D134542: [Concepts] Recover properly from a RecoveryExpr in a concept

erichkeane marked 2 inline comments as done. erichkeane added a comment. In D134542#3812292 , @erichkeane wrote: > In D134542#3812211 , @ychen wrote: > >> The patch looks good. Two high-level questions: >> >> - D

[PATCH] D134542: [Concepts] Recover properly from a RecoveryExpr in a concept

erichkeane marked 3 inline comments as done. erichkeane added a subscriber: tahonermann. erichkeane added a comment. In D134542#3812211 , @ychen wrote: > The patch looks good. Two high-level questions: > > - Does the similar thing happen for class templat

[PATCH] D134542: [Concepts] Recover properly from a RecoveryExpr in a concept

ychen added a comment. The patch looks good. Two high-level questions: - Does the similar thing happen for class templates? Like a constraint expr of a partial specialization has an error. Maybe we don't assert in this case? - I suppose the constraint error does not always affect the overload re

[PATCH] D134542: [Concepts] Recover properly from a RecoveryExpr in a concept

erichkeane created this revision. erichkeane added a reviewer: clang-language-wg. Herald added a project: All. erichkeane requested review of this revision. Discovered by reducing a different problem, we currently assert because we failed to make the constraint expressions not dependent, since a R