This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG6e83209f623e: [clang][Interp] Fix copy constructors with
record array members (authored by tbaeder).
Changed prior to commit:
https://reviews.llvm
tbaeder added inline comments.
Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:332
+ // ArrayIndex might not be set if a ArrayInitIndexExpr is being evaluated
+ // stand-alone, e.g. via EvaluateAsInt().
+ if (!ArrayIndex)
erichkeane wrote:
> For my edific
tbaeder updated this revision to Diff 463094.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D134523/new/
https://reviews.llvm.org/D134523
Files:
clang/lib/AST/Interp/ByteCodeExprGen.cpp
clang/lib/AST/Interp/Interp.h
clang/lib/AST/Interp/Pointer.cpp
clang/test/AST/Interp/records.cp
erichkeane added inline comments.
Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:332
+ // ArrayIndex might not be set if a ArrayInitIndexExpr is being evaluated
+ // stand-alone, e.g. via EvaluateAsInt().
+ if (!ArrayIndex)
For my edification: what repro
tbaeder added inline comments.
Comment at: clang/test/AST/Interp/records.cpp:160-163
+//static_assert(LT2.v[0].first == false, "");
+//static_assert(LT2.v[0].second == false, "");
+//static_assert(LT2.v[2].first == true, "");
+//static_assert(LT2.v[2].second == false, "");
--
tbaeder created this revision.
tbaeder added reviewers: aaron.ballman, erichkeane, shafik, tahonermann.
Herald added a project: All.
tbaeder requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Previously, we were only handling arrays of arrays
