[PATCH] D134352: [AArch64] Add Neoverse V2 CPU support

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. david-arm marked 3 inline comments as done. Closed by commit rGfbb119412f14: [AArch64] Add Neoverse V2 CPU support (authored by david-arm). Changed prior to commit:

[PATCH] D134352: [AArch64] Add Neoverse V2 CPU support

paulwalker-arm accepted this revision. paulwalker-arm added inline comments. Comment at: clang/docs/ReleaseNotes.rst:376 them, which it cannot. +- Add driver and tuning support for Neoverse V2 support via the flag + ``-mcpu=neoverse-v2``. Native detection is also supported vi

[PATCH] D134352: [AArch64] Add Neoverse V2 CPU support

Matt added a comment. OK, thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134352/new/ https://reviews.llvm.org/D134352 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D134352: [AArch64] Add Neoverse V2 CPU support

david-arm marked 3 inline comments as done. david-arm added inline comments. Comment at: llvm/include/llvm/Support/AArch64TargetParser.def:239 +AARCH64_CPU_NAME("neoverse-v2", ARMV9A, FK_NEON_FP_ARMV8, false, + (AArch64::AEK_SVE | AArch64::AEK_SVE2 | AArch64::AEK_

[PATCH] D134352: [AArch64] Add Neoverse V2 CPU support

david-arm updated this revision to Diff 462833. david-arm added a comment. - Added SVE2BITPERM to AArch64TargetParser.def and updated the unit test. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134352/new/ https://reviews.llvm.org/D134352 Files: clang/docs/ReleaseNotes.rst clang/t

[PATCH] D134352: [AArch64] Add Neoverse V2 CPU support

Matt added inline comments. Comment at: llvm/include/llvm/Support/AArch64TargetParser.def:239 +AARCH64_CPU_NAME("neoverse-v2", ARMV9A, FK_NEON_FP_ARMV8, false, + (AArch64::AEK_SVE | AArch64::AEK_SVE2 | AArch64::AEK_SSBS | + AArch64::AEK_FP16 | AAr

[PATCH] D134352: [AArch64] Add Neoverse V2 CPU support

dmgreen accepted this revision. dmgreen added a comment. This revision is now accepted and ready to land. Thanks. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134352/new/ https://reviews.llvm.org/D134352 ___ cfe-commits mailing list cfe

[PATCH] D134352: [AArch64] Add Neoverse V2 CPU support

david-arm updated this revision to Diff 462420. david-arm added a comment. - Added AEK_MTE to target parser flags. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134352/new/ https://reviews.llvm.org/D134352 Files: clang/docs/ReleaseNotes.rst clang/test/Driver/aarch64-mcpu.c clang/

[PATCH] D134352: [AArch64] Add Neoverse V2 CPU support

tschuett added inline comments. Comment at: llvm/include/llvm/Support/AArch64TargetParser.def:238 AArch64::AEK_RAND | AArch64::AEK_FP16FML | AArch64::AEK_I8MM)) +AARCH64_CPU_NAME("neoverse-v2", ARMV9A, FK_NEON_FP_ARMV8, false, + (AArch64::AEK_S

[PATCH] D134352: [AArch64] Add Neoverse V2 CPU support

dmgreen added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64.td:1112 + FeatureNEON, FeatureSVE2BitPerm, FeatureFP16FML, + FeatureMTE, FeatureRandGen]; list Saphira= [HasV8_4aOps, Fea

[PATCH] D134352: [AArch64] Add Neoverse V2 CPU support

david-arm added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64.td:1112 + FeatureNEON, FeatureSVE2BitPerm, FeatureFP16FML, + FeatureMTE, FeatureRandGen]; list Saphira= [HasV8_4aOps, F

[PATCH] D134352: [AArch64] Add Neoverse V2 CPU support

Matt added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64.td:1112 + FeatureNEON, FeatureSVE2BitPerm, FeatureFP16FML, + FeatureMTE, FeatureRandGen]; list Saphira= [HasV8_4aOps, Featur

[PATCH] D134352: [AArch64] Add Neoverse V2 CPU support

david-arm added a comment. In D134352#3806896 , @tschuett wrote: > `VScaleForTuning` is 1 for N2 and V2. It is 2 for V1. I though the V2 is more > like the V1 than the N2? > Sorry. This is throughput right? Hi @tschuett, Neoverse V2 will have 128-bit SV

[PATCH] D134352: [AArch64] Add Neoverse V2 CPU support

david-arm updated this revision to Diff 462124. david-arm added a comment. - Added FEAT_RNG to the neoverse-v2 CPU. - Added message to release notes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134352/new/ https://reviews.llvm.org/D134352 Files: clang/docs/ReleaseNotes.rst clang/

[PATCH] D134352: [AArch64] Add Neoverse V2 CPU support

dmgreen added a comment. Oh, A release note would be good to add too. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134352/new/ https://reviews.llvm.org/D134352 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D134352: [AArch64] Add Neoverse V2 CPU support

dmgreen added a comment. Thanks. Should RNG be added? And Why is Crypto no longer enabled? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134352/new/ https://reviews.llvm.org/D134352 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http

[PATCH] D134352: [AArch64] Add Neoverse V2 CPU support

tschuett added a comment. `VScaleForTuning` is 1 for N2 and V2. It is 2 for V1. I though the V2 is more like the V1 than the N2? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134352/new/ https://reviews.llvm.org/D134352 ___ cfe-commits maili

[PATCH] D134352: [AArch64] Add Neoverse V2 CPU support

david-arm marked 3 inline comments as done. david-arm added a comment. Thanks for the quick review @dmgreen! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134352/new/ https://reviews.llvm.org/D134352 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D134352: [AArch64] Add Neoverse V2 CPU support

david-arm updated this revision to Diff 461898. david-arm added a comment. - Changed lists of tuning features. - Removed redundant arch features from list. - Combined neoverse-v2 and neoverse-n2 cases together in AArch64Subtarget. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134352/new/

[PATCH] D134352: [AArch64] Add Neoverse V2 CPU support

dmgreen added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64.td:941 + "Neoverse V2 ARM processors", [ + FeaturePostRAScheduler]>; + Please add FeatureFuseAES and FeatureLSLFas

[PATCH] D134352: [AArch64] Add Neoverse V2 CPU support

david-arm created this revision. david-arm added reviewers: sdesmalen, paulwalker-arm, dmgreen, MarkMurrayARM, CarolineConcatto. Herald added subscribers: hiraditya, kristof.beyls. Herald added a project: All. david-arm requested review of this revision. Herald added projects: clang, LLVM. Herald