This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG10378c45055f: [HLSL] Enable availability attribute (authored
by beanz).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://r
erichkeane added a comment.
Still looks good to me, no nits. As far as using the bookmarks, I tend to use
them for things that are 'far away' instead of 'right here', and stick to the
@+/@- bits for 'local' ones.
Comment at: clang/test/SemaHLSL/AvailabilityMarkup.hlsl:13
+vo
beanz updated this revision to Diff 460879.
beanz added a comment.
Updating test cases to use labels and sort the matches.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D134067/new/
https://reviews.llvm.org/D134067
Files:
clang/include/clang/Basi
beanz added inline comments.
Comment at: clang/test/SemaHLSL/AvailabilityMarkup.hlsl:15
+void fn() {
+// expected-warning@+2 {{'fn6_0' is only available on HLSL ShaderModel 6.0
or newer}}
+// expected-note@+1 {{enclose 'fn6_0' in a __builtin_available check to
silence t
erichkeane accepted this revision.
erichkeane added a comment.
This revision is now accepted and ready to land.
Besides the request for re-organizing the the test files, LGTM.
Comment at: clang/test/SemaHLSL/AvailabilityMarkup.hlsl:15
+void fn() {
+// expected-warning@+2 {{
beanz updated this revision to Diff 460869.
beanz added a comment.
Updating based on feedback from @erichkeane. Thank you for the fast feedback!
- Moved ShaderModel check into a switch case.
- Added additional self-contained test case with more variations.
Repository:
rG LLVM Github Monorepo
erichkeane added inline comments.
Comment at: clang/lib/Sema/SemaAvailability.cpp:198
+return Triple.getVendor() == llvm::Triple::Apple ||
+ Triple.getOS() == llvm::Triple::ShaderModel;
}
This should jsut be a 'case' label added above, we are alr
beanz created this revision.
beanz added reviewers: MaskRay, erichkeane, rnk, arphaman, python3kgae,
pow2clk, tex3d.
Herald added a reviewer: aaron.ballman.
Herald added subscribers: Anastasia, StephenFan.
Herald added a project: All.
beanz requested review of this revision.
Herald added a project
