erichkeane added a comment.
Still looks good to me, no nits. As far as using the bookmarks, I tend to use
them for things that are 'far away' instead of 'right here', and stick to the
@+/@- bits for 'local' ones.
================
Comment at: clang/test/SemaHLSL/AvailabilityMarkup.hlsl:13
+void fn() {
+ // expected-warning@#fn6_0_site {{'fn6_0' is only available on HLSL
ShaderModel 6.0 or newer}}
+ // expected-note@#fn6_0 {{'fn6_0' has been marked as being introduced in
HLSL ShaderModel 6.0 here, but the deployment target is HLSL ShaderModel 5.0}}
----------------
Your preference here, but the `@+3` here is acceptable when they are 'local'.
I have no preference either way.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D134067/new/
https://reviews.llvm.org/D134067
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
